public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/main] arc: libc, libgloss: Remove .file directive from .S files
@ 2024-05-22 18:27 Jeff Johnston
  0 siblings, 0 replies; only message in thread
From: Jeff Johnston @ 2024-05-22 18:27 UTC (permalink / raw)
  To: newlib-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=880d537347be5658afcedca6d4a04070dc1ce3bf

commit 880d537347be5658afcedca6d4a04070dc1ce3bf
Author: Yuriy Kolerov <kolerov93@gmail.com>
Date:   Tue May 21 10:56:46 2024 +0100

    arc: libc, libgloss: Remove .file directive from .S files
    
    Assembler for ARCv2 always extends the name provided by
    .file directive to an absolute form.
    
    On ARCv3 targets .file directive forces assembler to put
    a provided string to DW_AT_name field as is without
    extending to an absolute path. Then GDB cannot find
    source files because of it.
    
    The best way to fix this issue is just delete lines
    with .file directive in .S files and let the compiler
    to decide what DW_AT_name must contain. Particularly,
    the compiler fills this filed by an absolute path to
    a .S file because only absolute paths are used in
    toolchain's build process.
    
    Signed-off-by: Yuriy Kolerov <kolerov93@gmail.com>

Diff:
---
 libgloss/arc/crt0.S              | 3 +--
 newlib/libc/machine/arc/setjmp.S | 4 +---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/libgloss/arc/crt0.S b/libgloss/arc/crt0.S
index 8d9adaa52..6c24e8dcb 100644
--- a/libgloss/arc/crt0.S
+++ b/libgloss/arc/crt0.S
@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2015-2016, Synopsys, Inc. All rights reserved.
+   Copyright (c) 2015-2024, Synopsys, Inc. All rights reserved.
 
    Redistribution and use in source and binary forms, with or without
    modification, are permitted provided that the following conditions are met:
@@ -55,7 +55,6 @@
 #define __ARCHS__ 1
 #endif
 
-	.file	"crt0.S"
 	.extern main
 
 #if defined (__ARCEM__) || defined (__ARCHS__)
diff --git a/newlib/libc/machine/arc/setjmp.S b/newlib/libc/machine/arc/setjmp.S
index 8e824f5cc..bd6acdcc4 100644
--- a/newlib/libc/machine/arc/setjmp.S
+++ b/newlib/libc/machine/arc/setjmp.S
@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2015, Synopsys, Inc. All rights reserved.
+   Copyright (c) 2015-2024, Synopsys, Inc. All rights reserved.
 
    Redistribution and use in source and binary forms, with or without
    modification, are permitted provided that the following conditions are met:
@@ -32,8 +32,6 @@
    these are the stack mappings for the registers
    as stored in the ABI for ARC */
 
-       .file "setjmp.S"
-
 ABIr13	= 0
 ABIr14	= ABIr13 + 4
 ABIr15	= ABIr14 + 4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-05-22 18:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-22 18:27 [newlib-cygwin/main] arc: libc, libgloss: Remove .file directive from .S files Jeff Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).