From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: aditya upadhyay <aadit0402@gmail.com>, newlib@sourceware.org
Subject: Re: Importing cacoshl.c and its dependent methos,
Date: Wed, 21 Jun 2017 06:46:00 -0000 [thread overview]
Message-ID: <0205aa55-7b80-245d-0af6-4fe67c15429f@embedded-brains.de> (raw)
In-Reply-To: <CAMZxAxe-Gj+kqQRxUp3g9OK0Mk57uAVmTKqL4N5T-hPBUXXWYQ@mail.gmail.com>
On 21/06/17 04:24, aditya upadhyay wrote:
> Hello Developers,
> In cacoshl.c, There is a dependency between cacoshl.c and csqrtl.c.
> In ported csqrtl.c from NetBSD, stdbool.h is there, But i saw there
> is no stdbool.h.
>
> So for bool data type, I have used enum. Is it a right way or not.
> please suggest or do i have to use stdbool.h from gcc library ?
<stdbool.h> is currently not used by Newlib. I am not sure if we should
add this dependency if its only needed by csqrtl.c (in overall NetBSD
libm) and not visible to the user.
I would replace the #include <stdbool.h> with
#ifndef __cplusplus
typedef enum { false, true } bool;
#endif
and keep the rest of the code unchanged.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
next prev parent reply other threads:[~2017-06-21 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 2:25 aditya upadhyay
2017-06-21 6:46 ` Sebastian Huber [this message]
2017-06-21 8:28 ` Corinna Vinschen
2017-06-21 12:05 ` aditya upadhyay
2017-06-21 15:02 ` Craig Howland
2017-06-21 15:09 ` Joel Sherrill
2017-06-21 15:18 ` Craig Howland
2017-06-26 6:05 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0205aa55-7b80-245d-0af6-4fe67c15429f@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=aadit0402@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).