[PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Joel Sherrill]

---
 newlib/MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
index 6117ff4..0bd93ff 100644
--- a/newlib/MAINTAINERS
+++ b/newlib/MAINTAINERS
@@ -45,6 +45,12 @@ aarch64			Richard Earnshaw	richard.earnshaw@arm.com
 msp430			DJ Delorie		dj@redhat.com
 			Nick Clifton		nickc@redhat.com
 
+			OS Port Maintainers	(OS alphabetical order)
+
+OS port maintainers may make changes in OS-specific directories, as
+well as OS-specific portions of the build system, without approval.
+
+RTEMS			Joel Sherrill		joel.sherrill@oarcorp.com
 
 			Write After Approval
 
@@ -57,3 +63,4 @@ Nick Clifton			nickc@redhat.com
 Eric Blake			eblake@redhat.com
 Will Newton			will.newton@linaro.org
 Sebastian Huber			sebastian.huber@embedded-brains.de
+Joel Sherrill			joel.sherrill@oarcorp.com
-- 
1.8.3.1

[PATCH 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS

[Joel Sherrill]

The *-*-rtems* targets defined this even though the conditional
was no longer present in i386/setjmp.S.
---
 newlib/configure.host | 2 --
 1 file changed, 2 deletions(-)

diff --git a/newlib/configure.host b/newlib/configure.host
index ba2d8c6..fb3362b 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -608,8 +608,6 @@ case "${host}" in
 	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
         # turn off unsupported items in posix directory 
 	newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT -D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN -D_NO_POSIX_SPAWN"
-        # turn off using cli/sti in i386 setjmp/longjmp
-	newlib_cflags="${newlib_cflags} -D_I386MACH_ALLOW_HW_INTERRUPTS"
 	;;
 # VxWorks supplies its own version of malloc, and the newlib one
 # doesn't work because VxWorks does not have sbrk.
-- 
1.8.3.1

[PATCH 2/2] newlib/.../getreent.c: Allow to be provided by host and do so for RTEMS

[Joel Sherrill]

RTEMS provides the option to have a global or per-thread reentrancy
as part of application configuration. As part of this, RTEMS provides
the implementation of __getreent() as appropriate. Allow the target
to determine if this method is present in libc.a.
---
 newlib/configure.host        | 4 +++-
 newlib/libc/reent/getreent.c | 8 ++++++++
 newlib/libc/sys/rtems/crt0.c | 3 +++
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/newlib/configure.host b/newlib/configure.host
index fb3362b..f2049f4 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -605,9 +605,11 @@ case "${host}" in
 	default_newlib_io_long_long="yes"
 	default_newlib_io_c99_formats="yes"
 	newlib_cflags="${newlib_cflags} -D_COMPILING_NEWLIB"
-	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
+	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DGETREENT_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
         # turn off unsupported items in posix directory 
 	newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT -D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN -D_NO_POSIX_SPAWN"
+        # turn off using cli/sti in i386 setjmp/longjmp
+	newlib_cflags="${newlib_cflags} -D_I386MACH_ALLOW_HW_INTERRUPTS"
 	;;
 # VxWorks supplies its own version of malloc, and the newlib one
 # doesn't work because VxWorks does not have sbrk.
diff --git a/newlib/libc/reent/getreent.c b/newlib/libc/reent/getreent.c
index 60ae6fb..124abce 100644
--- a/newlib/libc/reent/getreent.c
+++ b/newlib/libc/reent/getreent.c
@@ -1,5 +1,11 @@
 /* default reentrant pointer when multithread enabled */
 
+#ifdef GETREENT_PROVIDED
+
+int _dummy_getreent;
+
+#else
+
 #include <_ansi.h>
 #include <reent.h>
 
@@ -12,3 +18,5 @@ _DEFUN_VOID(__getreent)
 {
   return _impure_ptr;
 }
+
+#endif
diff --git a/newlib/libc/sys/rtems/crt0.c b/newlib/libc/sys/rtems/crt0.c
index 0e9d426..4e2c207 100644
--- a/newlib/libc/sys/rtems/crt0.c
+++ b/newlib/libc/sys/rtems/crt0.c
@@ -125,6 +125,9 @@ RTEMS_STUB(int, waitpid (pid_t pid, int *status, int options), { return -1; })
 #endif
 RTEMS_STUB(_ssize_t, write (int fd, const void *buf, size_t nbytes), { return -1; })
 
+/* stubs for functions from sys/reent.h */
+RTEMS_STUB(struct _reent *, __getreent (), { })
+
 /* stubs for functions from reent.h */
 RTEMS_STUB(int, _close_r (struct _reent *r, int fd), { return -1; })
 #if defined(_NO_EXECVE)
-- 
1.8.3.1

Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Joel Sherrill]

Ignore this. It was just laying around and git send-email
picked it up. It has already been discussed and merged.

On 10/10/2017 9:36 AM, Joel Sherrill wrote:
> ---
>   newlib/MAINTAINERS | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
> index 6117ff4..0bd93ff 100644
> --- a/newlib/MAINTAINERS
> +++ b/newlib/MAINTAINERS
> @@ -45,6 +45,12 @@ aarch64			Richard Earnshaw	richard.earnshaw@arm.com
>   msp430			DJ Delorie		dj@redhat.com
>   			Nick Clifton		nickc@redhat.com
>   
> +			OS Port Maintainers	(OS alphabetical order)
> +
> +OS port maintainers may make changes in OS-specific directories, as
> +well as OS-specific portions of the build system, without approval.
> +
> +RTEMS			Joel Sherrill		joel.sherrill@oarcorp.com
>   
>   			Write After Approval
>   
> @@ -57,3 +63,4 @@ Nick Clifton			nickc@redhat.com
>   Eric Blake			eblake@redhat.com
>   Will Newton			will.newton@linaro.org
>   Sebastian Huber			sebastian.huber@embedded-brains.de
> +Joel Sherrill			joel.sherrill@oarcorp.com
> 

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35806
Support Available                (256) 722-9985

Re: [PATCH 2/2] newlib/.../getreent.c: Allow to be provided by host and do so for RTEMS

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Hi Joel,

On Oct 10 09:36, Joel Sherrill wrote:
> RTEMS provides the option to have a global or per-thread reentrancy
> as part of application configuration. As part of this, RTEMS provides
> the implementation of __getreent() as appropriate. Allow the target
> to determine if this method is present in libc.a.
> ---
>  newlib/configure.host        | 4 +++-
>  newlib/libc/reent/getreent.c | 8 ++++++++
>  newlib/libc/sys/rtems/crt0.c | 3 +++
>  3 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/newlib/configure.host b/newlib/configure.host
> index fb3362b..f2049f4 100644
> --- a/newlib/configure.host
> +++ b/newlib/configure.host
> @@ -605,9 +605,11 @@ case "${host}" in
>  	default_newlib_io_long_long="yes"
>  	default_newlib_io_c99_formats="yes"
>  	newlib_cflags="${newlib_cflags} -D_COMPILING_NEWLIB"
> -	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
> +	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DGETREENT_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
>          # turn off unsupported items in posix directory 
>  	newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT -D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN -D_NO_POSIX_SPAWN"
> +        # turn off using cli/sti in i386 setjmp/longjmp
> +	newlib_cflags="${newlib_cflags} -D_I386MACH_ALLOW_HW_INTERRUPTS"

Patch 1 removes these lines and patch 2 reverts them?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]