From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: free() and implicit conversion to a function pointer (was: Use of initialized variable in strtod.c)
Date: Thu, 16 Mar 2017 08:40:00 -0000 [thread overview]
Message-ID: <20170316083958.GC16777@calimero.vinschen.de> (raw)
In-Reply-To: <CAH8yC8nz1-77rgpZ_Q2-M8tW3CLg4gMjshR+HNDsgEZLQ=tezQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
On Mar 15 18:48, Jeffrey Walton wrote:
> > But this in __call_atexit.c is definitely correct. It is
> > treating free() as a weak symbol and the only way to
> > silence Coverity is to add an annotation.
> >
> > 136 /* Don't dynamically free the atexit array if free is not
> > 137 available. */
> >
> > CID 175323 (#1 of 1): Function address comparison (BAD_COMPARE)
> > func_conv: This implicit conversion to a function pointer is suspicious:
> > free.
> > Did you intend to call free?
> > 138 if (!free)
> > 139 break;
>
> Well, I have not encountered that one (yet). Since Coverity is
> complaining about an implicit conversion, maybe the following will
> help to avoid the implicit part (and sidestep the finding):
>
> if (free != NULL)
> break;
>
> Or perhaps:
>
> if ((void*)free != NULL)
> break;
>
> If that works to clear the finding, then it is one of those items I
> write-off as "working and playing well with the tools".
Unfortunately you have to tell covreity that "free" is a var, not a function,
but since that's not generally true... marking as false positive.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-03-16 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 22:48 Jeffrey Walton
2017-03-16 8:40 ` Corinna Vinschen [this message]
2017-03-16 15:04 ` Joel Sherrill
2017-03-16 16:23 ` Bob Dunlop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316083958.GC16777@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).