From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] Print sign of NaN values
Date: Wed, 07 Jun 2017 09:58:00 -0000 [thread overview]
Message-ID: <20170607095826.GA18287@calimero.vinschen.de> (raw)
In-Reply-To: <CA+yXCZDdAiq-ys1q+8BNHthku-75o2EXk-+KoHR7y_RQDxhEQw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Jun 7 14:55, Kito Cheng wrote:
> Hi Craig:
>
> Thanks your review :)
>
> here is updated patch.
>
> On Tue, Jun 6, 2017 at 12:45 AM, Craig Howland
> <howland@lgsinnovations.com> wrote:
> > On 06/03/2017 09:54 AM, Kito Cheng wrote:
> >>
> >> This patch let -NaN can print the right sign like glibc do[1] :)
> >>
> >> Ref:
> >> [1]
> >> https://sourceware.org/git/?p=glibc.git;a=commit;h=003c9895a89e71767ad64bafac1ca99622be2eb7
> >
> > For vfwprintf.c, the two assignments to sign ought to be "sign = L'-';"
> > (missing the L).
> >
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-06-07 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 13:54 Kito Cheng
2017-06-05 16:46 ` Craig Howland
2017-06-07 6:56 ` Kito Cheng
2017-06-07 9:58 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607095826.GA18287@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).