From: Kito Cheng <kito.cheng@gmail.com>
To: Craig Howland <howland@lgsinnovations.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] Print sign of NaN values
Date: Wed, 07 Jun 2017 06:56:00 -0000 [thread overview]
Message-ID: <CA+yXCZDdAiq-ys1q+8BNHthku-75o2EXk-+KoHR7y_RQDxhEQw@mail.gmail.com> (raw)
In-Reply-To: <0aab66f6-20a6-10ec-f399-2a39799ab980@LGSInnovations.com>
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
Hi Craig:
Thanks your review :)
here is updated patch.
On Tue, Jun 6, 2017 at 12:45 AM, Craig Howland
<howland@lgsinnovations.com> wrote:
> On 06/03/2017 09:54 AM, Kito Cheng wrote:
>>
>> This patch let -NaN can print the right sign like glibc do[1] :)
>>
>> Ref:
>> [1]
>> https://sourceware.org/git/?p=glibc.git;a=commit;h=003c9895a89e71767ad64bafac1ca99622be2eb7
>
> For vfwprintf.c, the two assignments to sign ought to be "sign = L'-';"
> (missing the L).
>
[-- Attachment #2: 0001-Print-sign-of-NaN-values.patch --]
[-- Type: text/x-patch, Size: 1523 bytes --]
From 93a618861e85a404a9ad7e4933dab566a55e1d5f Mon Sep 17 00:00:00 2001
From: Kito Cheng <kito.cheng@gmail.com>
Date: Sat, 3 Jun 2017 21:41:29 +0800
Subject: [PATCH] Print sign of NaN values.
---
newlib/libc/stdio/vfprintf.c | 4 ++++
newlib/libc/stdio/vfwprintf.c | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/newlib/libc/stdio/vfprintf.c b/newlib/libc/stdio/vfprintf.c
index ed92bb2..3585423 100644
--- a/newlib/libc/stdio/vfprintf.c
+++ b/newlib/libc/stdio/vfprintf.c
@@ -1245,6 +1245,8 @@ reswitch: switch (ch) {
break;
}
if (isnan (_fpvalue)) {
+ if (signbit (_fpvalue))
+ sign = '-';
if (ch <= 'G') /* 'A', 'E', 'F', or 'G' */
cp = "NAN";
else
@@ -1276,6 +1278,8 @@ reswitch: switch (ch) {
break;
}
if (expt == 1) {
+ if (signbit (_fpvalue))
+ sign = '-';
if (ch <= 'G') /* 'A', 'E', 'F', or 'G' */
cp = "NAN";
else
diff --git a/newlib/libc/stdio/vfwprintf.c b/newlib/libc/stdio/vfwprintf.c
index f0179a0..4786ed6 100644
--- a/newlib/libc/stdio/vfwprintf.c
+++ b/newlib/libc/stdio/vfwprintf.c
@@ -970,6 +970,8 @@ reswitch: switch (ch) {
break;
}
if (isnan (_fpvalue)) {
+ if (signbit (_fpvalue))
+ sign = L'-';
if (ch <= L'G') /* 'A', 'E', 'F', or 'G' */
cp = L"NAN";
else
@@ -1001,6 +1003,8 @@ reswitch: switch (ch) {
break;
}
if (expt == 1) {
+ if (signbit (_fpvalue))
+ sign = L'-';
if (ch <= L'G') /* 'A', 'E', 'F', or 'G' */
cp = L"NAN";
else
--
2.7.4
next prev parent reply other threads:[~2017-06-07 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 13:54 Kito Cheng
2017-06-05 16:46 ` Craig Howland
2017-06-07 6:56 ` Kito Cheng [this message]
2017-06-07 9:58 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZDdAiq-ys1q+8BNHthku-75o2EXk-+KoHR7y_RQDxhEQw@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=howland@lgsinnovations.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).