From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] Fix RTEMS ioctl() declaration
Date: Wed, 07 Jun 2017 13:11:00 -0000 [thread overview]
Message-ID: <20170607131105.GB15217@calimero.vinschen.de> (raw)
In-Reply-To: <20170607090821.14403-1-sebastian.huber@embedded-brains.de>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Jun 7 11:08, Sebastian Huber wrote:
> Using uint32_t for ioctl_command_t does not work well on 64-bit targets.
>
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
> newlib/libc/sys/rtems/include/sys/ioccom.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/newlib/libc/sys/rtems/include/sys/ioccom.h b/newlib/libc/sys/rtems/include/sys/ioccom.h
> index 9c5350d1e..2c0e9ee71 100644
> --- a/newlib/libc/sys/rtems/include/sys/ioccom.h
> +++ b/newlib/libc/sys/rtems/include/sys/ioccom.h
> @@ -36,7 +36,7 @@
> #include <sys/types.h>
> #include <stdint.h>
>
> -typedef uint32_t ioctl_command_t;
> +typedef unsigned long ioctl_command_t;
Why do you need a ioctl_command_t at all? It's not in FreeBSD either.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-07 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 9:08 Sebastian Huber
2017-06-07 13:11 ` Corinna Vinschen [this message]
2017-06-07 13:14 ` Sebastian Huber
2017-06-07 14:27 ` Corinna Vinschen
2017-06-08 5:33 ` Sebastian Huber
2017-06-09 13:36 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607131105.GB15217@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).