Importing ccoshl.c from netbsd

Importing ccoshl.c from netbsd

[aditya upadhyay]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

Hello Developers,

I have ported ccoshl.c from netbsd. I am requesting you to please
review the patch for the same and suggest me any required
modification.

Thanks & Regards,
Aditya Upadhyay

[-- Attachment #2: 0001-Importing-ccoshl.c-from-netbsd.patch --]
[-- Type: text/x-patch, Size: 3051 bytes --]

From e54e19aee2ab30737f9b1a20c0774eb282a2edd8 Mon Sep 17 00:00:00 2001
From: Aditya Upadhyay <aadit0402@gmail.com>
Date: Tue, 13 Jun 2017 00:46:22 +0530
Subject: [PATCH] Importing ccoshl.c from netbsd.

---
 newlib/libm/complex/Makefile.am |  2 +-
 newlib/libm/complex/ccoshl.c    | 45 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 newlib/libm/complex/ccoshl.c

diff --git a/newlib/libm/complex/Makefile.am b/newlib/libm/complex/Makefile.am
index 6ba49b6..402053f 100644
--- a/newlib/libm/complex/Makefile.am
+++ b/newlib/libm/complex/Makefile.am
@@ -10,7 +10,7 @@ src = cabs.c cacos.c cacosh.c carg.c casin.c casinh.c \
       cpow.c cproj.c  creal.c  \
       csin.c csinh.c csqrt.c ctan.c ctanh.c
 
-lsrc = cabsl.c creall.c cimagl.c
+lsrc = cabsl.c creall.c cimagl.c ccoshl.c
 
 fsrc =	cabsf.c casinf.c ccosf.c cimagf.c cprojf.c  \
         csqrtf.c cacosf.c casinhf.c ccoshf.c clogf.c clog10f.c \
diff --git a/newlib/libm/complex/ccoshl.c b/newlib/libm/complex/ccoshl.c
new file mode 100644
index 0000000..869549f
--- /dev/null
+++ b/newlib/libm/complex/ccoshl.c
@@ -0,0 +1,45 @@
+/* $NetBSD: ccoshl.c,v 1.1 2014/10/10 00:48:18 christos Exp $ */
+
+/*-
+ * Copyright (c) 2007 The NetBSD Foundation, Inc.
+ * All rights reserved.
+ *
+ * This code is derived from software written by Stephen L. Moshier.
+ * It is redistributed by the NetBSD Foundation by permission of the author.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <complex.h>
+#include <math.h>
+
+long double complex
+ccoshl(long double complex z)
+{
+  long double complex w;
+  long double x, y;
+
+  x = creall(z);
+  y = cimagl(z);
+  w = coshl(x) * cosl(y) + (sinhl(x) * sinl(y)) * I;
+  return w;
+}
-- 
2.7.4

Re: Importing ccoshl.c from netbsd

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

On Jun 13 00:49, aditya upadhyay wrote:
> Hello Developers,
> 
> I have ported ccoshl.c from netbsd. I am requesting you to please
> review the patch for the same and suggest me any required
> modification.
> 
> Thanks & Regards,
> Aditya Upadhyay

> From e54e19aee2ab30737f9b1a20c0774eb282a2edd8 Mon Sep 17 00:00:00 2001
> From: Aditya Upadhyay <aadit0402@gmail.com>
> Date: Tue, 13 Jun 2017 00:46:22 +0530
> Subject: [PATCH] Importing ccoshl.c from netbsd.

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Importing ccoshl.c from netbsd

[Sebastian Huber]

Hello,

On 12/06/17 21:19, aditya upadhyay wrote:
> +  long double complex w;

the original NetBSD file uses one tab for the indentation. Should we 
really perform white space changes on imported files?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: Importing ccoshl.c from netbsd

[aditya upadhyay]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

I have gone through the link what you have sent. I should not reformat
the coding style of third party code.
Please review the modified patch.

Thanks & Regards,
Aditya Upadhyay

On Tue, Jun 13, 2017 at 6:58 PM, Sebastian Huber
<sebastian.huber@embedded-brains.de> wrote:
> On 13/06/17 15:26, aditya upadhyay wrote:
>
>> Sorry for that. I have used the rtems coding style and conventions. I am
>> investigating previously commited file or please suggest me docs for newlib
>> coding style and conventions.
>
>
> https://devel.rtems.org/wiki/Developer/Coding/Conventions#ExceptionstotheRules
>
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber@embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>

[-- Attachment #2: 0002-Importing-ccoshl.c-from-netbsd.patch --]
[-- Type: text/x-patch, Size: 3049 bytes --]

From 9f532f2e014dd23c2a8f28868f403e7aa2d119d8 Mon Sep 17 00:00:00 2001
From: Aditya Upadhyay <aadit0402@gmail.com>
Date: Tue, 13 Jun 2017 21:57:09 +0530
Subject: [PATCH 2/2] Importing ccoshl.c from netbsd.

---
 newlib/libm/complex/Makefile.am |  2 +-
 newlib/libm/complex/ccoshl.c    | 45 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 newlib/libm/complex/ccoshl.c

diff --git a/newlib/libm/complex/Makefile.am b/newlib/libm/complex/Makefile.am
index 6ba49b6..402053f 100644
--- a/newlib/libm/complex/Makefile.am
+++ b/newlib/libm/complex/Makefile.am
@@ -10,7 +10,7 @@ src = cabs.c cacos.c cacosh.c carg.c casin.c casinh.c \
       cpow.c cproj.c  creal.c  \
       csin.c csinh.c csqrt.c ctan.c ctanh.c
 
-lsrc = cabsl.c creall.c cimagl.c
+lsrc = cabsl.c creall.c cimagl.c ccoshl.c
 
 fsrc =	cabsf.c casinf.c ccosf.c cimagf.c cprojf.c  \
         csqrtf.c cacosf.c casinhf.c ccoshf.c clogf.c clog10f.c \
diff --git a/newlib/libm/complex/ccoshl.c b/newlib/libm/complex/ccoshl.c
new file mode 100644
index 0000000..f59fadf
--- /dev/null
+++ b/newlib/libm/complex/ccoshl.c
@@ -0,0 +1,45 @@
+/* $NetBSD: ccoshl.c,v 1.1 2014/10/10 00:48:18 christos Exp $ */
+
+/*-
+ * Copyright (c) 2007 The NetBSD Foundation, Inc.
+ * All rights reserved.
+ *
+ * This code is derived from software written by Stephen L. Moshier.
+ * It is redistributed by the NetBSD Foundation by permission of the author.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <complex.h>
+#include <math.h>
+
+long double complex
+ccoshl(long double complex z)
+{
+	long double complex w;
+	long double x, y;
+
+	x = creall(z);
+	y = cimagl(z);
+	w = coshl(x) * cosl(y) + (sinhl(x) * sinl(y)) * I;
+	return w;
+}
-- 
2.7.4

Re: Importing ccoshl.c from netbsd

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

On Jun 13 22:03, aditya upadhyay wrote:
> I have gone through the link what you have sent. I should not reformat
> the coding style of third party code.
> Please review the modified patch.

Since I already pushed it I just applied a formatting fix.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]