From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: Adding Methods related to inttypes.h
Date: Wed, 14 Jun 2017 08:44:00 -0000 [thread overview]
Message-ID: <20170614084406.GP13513@calimero.vinschen.de> (raw)
In-Reply-To: <cc1fb03d-7b77-45f0-9f48-76da016063ff@embedded-brains.de>
[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]
On Jun 14 07:42, Sebastian Huber wrote:
> On 13/06/17 21:03, aditya upadhyay wrote:
>
> > Hello Developers,
> >
> > I have ported the methods what are declared inside the inttypes.h
> > header file from freebsd. I am requesting you to please review the
> > code.
> >
> > I am not able to push the code of ccoshl.c in my forked repo. It is
> > saying fatal error. I do not know how to apply the signature.asc file.
> > Please have a look on my issue.
> > [...]
> > newlib/libc/Makefile.am | 4 +-
> > newlib/libc/inttypes/Makefile.am | 24 +++++++
> > newlib/libc/inttypes/imaxabs.c | 44 ++++++++++++
> > newlib/libc/inttypes/imaxdiv.c | 53 ++++++++++++++
> > newlib/libc/inttypes/strtoimax.c | 144 +++++++++++++++++++++++++++++++++++++
> > newlib/libc/inttypes/strtoumax.c | 135 ++++++++++++++++++++++++++++++++++
> > newlib/libc/inttypes/wcstoimax.c | 151 +++++++++++++++++++++++++++++++++++++++
> > newlib/libc/inttypes/wcstoumax.c | 144 +++++++++++++++++++++++++++++++++++++
>
> These functions should probably go into "newlib/libc/stdlib" just like on
> FreeBSD and NetBSD. Where does this "inttypes" directory come from?
ACK.
Also, newlib already has functions strtoll, strtoull, wcstoll, wcstoull.
So the aliasing to strtoimax, etc, seems like a bad idea. In theory,
all we need is an aliasing from strtoll to strtoumax, etc, in the existing
sources.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-14 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 19:03 aditya upadhyay
2017-06-14 5:43 ` Sebastian Huber
2017-06-14 8:44 ` Corinna Vinschen [this message]
2017-06-14 9:25 ` Sebastian Huber
2017-06-14 10:53 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614084406.GP13513@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).