public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: Importing inttypes methods from FreeBSD
Date: Wed, 19 Jul 2017 15:44:00 -0000	[thread overview]
Message-ID: <20170719154430.GB6325@calimero.vinschen.de> (raw)
In-Reply-To: <d3a3400a-08c2-7033-6c8c-e0da3aa0b5e5@LGSInnovations.com>

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

On Jul 19 10:13, Craig Howland wrote:
> On 07/19/2017 08:28 AM, Corinna Vinschen wrote:
> > What you really want is to define a static function which takes the
> > reent pointer and strtoimax_l/strtoimax only calling that, like this:
> > 
> > --- snip ---
> > static intmax_t
> > _strtoimax_r(struct _reent *rptr, const char * __restrict nptr,
> > 	     char ** __restrict endptr, int base, locale_t loc)
> Corinna:
>      Why static?  In general, the reentrant forms are included in the header
> files so that they can be called directly if an application so desires.

Good point.  Yes, the function should better be non-static and added
to inttypes.h as well (unconditionally).


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-07-19 15:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 21:40 Aditya Upadhyay
2017-07-19  9:34 ` Sebastian Huber
2017-07-19 10:16   ` Aditya Upadhyay
2017-07-19 10:58     ` Sebastian Huber
2017-07-19 12:28 ` Corinna Vinschen
2017-07-19 13:23   ` Aditya Upadhyay
2017-07-19 14:13   ` Craig Howland
2017-07-19 15:44     ` Corinna Vinschen [this message]
2017-07-19 17:00       ` Aditya Upadhyay
2017-07-20  8:25         ` Aditya Upadhyay
2017-07-20 14:37           ` Corinna Vinschen
2017-07-21 15:43             ` Gedare Bloom
2017-07-21 19:31               ` Corinna Vinschen
  -- strict thread matches above, loose matches on Subject: below --
2017-07-11  6:01 Aditya Upadhyay
2017-07-11  3:29 Aditya Upadhyay
2017-07-11  9:06 ` Corinna Vinschen
     [not found]   ` <CAMZxAxccBx9oDRiVE-mw5JEcKrLW4GKTdvg-dt+8bTHU=5j54w@mail.gmail.com>
2017-07-12  9:50     ` Aditya Upadhyay
2017-07-12 12:07       ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719154430.GB6325@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).