Re: Importing inttypes methods from FreeBSD

[Corinna Vinschen <vinschen@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2106 bytes --]

Aditya,

On Jul 20 13:54, Aditya Upadhyay wrote:
> Hello All,
> 
> This is the modified patches for inttypes methods. Now I want to make
> testsuite for these methods in newlib, but i have no idea how to make
> test in newlib. Can anyone please help me for the same or point me
> some link. Please review the patch.

Sorry to say that, but this is unusable.  I can't apply the below
patches because they are missing the original patches.  On the other
hand you're using the original subjects, as if the below patches are the
entire thing.  They aren't.  The below patches are only relative
patches to the ones you orignally sent, but which, of course, haven't
been applied yet.  

Please, make yourself familiar with `git rebase -i'.  Go back to the
original patches actually adding the files imaxabs.c, etc., and squash
the below patches into the original patches.  Then send the resulting,
*complete* patches as a patchset.  Every addition like imaxabs.c should
be a single patch in the patchset.

> diff --git a/newlib/libc/stdlib/Makefile.am b/newlib/libc/stdlib/Makefile.am
> index 6cca5f005..d97b0250c 100644
> --- a/newlib/libc/stdlib/Makefile.am
> +++ b/newlib/libc/stdlib/Makefile.am
> @@ -34,7 +34,6 @@ GENERAL_SOURCES = \
>  	getenv_r.c	\
>  	itoa.c          \
>  	imaxabs.c	\
> -	imaxdiv.c	\
>  	labs.c 		\
>  	ldiv.c  	\
>  	ldtoa.c		\
> @@ -59,7 +58,6 @@ GENERAL_SOURCES = \
>  	sb_charsets.c	\
>  	strtod.c	\
>  	strtodg.c	\
> -	strtoimax.c	\
>  	strtol.c	\
>  	strtorx.c	\
>  	strtoul.c	\
> @@ -70,8 +68,8 @@ GENERAL_SOURCES = \
>  	wcstombs.c	\
>  	wcstombs_r.c	\
>  	wctomb.c	\
> -	wctomb_r.c
> -
> +	wctomb_r.c	\
> +	

^^^^^^^^^^^^
...and don't add gratuitious white spaces, please.

Joel, please take an interest in Aditya's work in the first place.
*You* were the one who gave these tasks to Aditya, so *you* should be
the one guiding him and reviewing these patches, not me.
For any followup patches, I will not look into them unless you gave
your OK first.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]