Re: Importing inttypes methods

[Corinna Vinschen <vinschen@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Jul 26 01:20, Aditya Upadhyay wrote:
> Hello All,
> 
> I have ported the inttypes methods from freeBSD. I have made all the
> possible changes whatever my mentors suggested me. I am requesting you
> to please review the same. Is this ok for master ?

The patches apply and build.  This looks 99% good now, thank you.

Just one last minor problem, which is my fault, not yours:

You named the reentrant functions _strtoimax_r, _wcstoumax_r, etc.,
which is basically right.

However, the *other*, equivalent reentrant, locale-specific functions
for other datatypes are all named with a trailing l: _strtol_l,
_wcstoull_l, etc.  In retrospect, this wasn't the brightest idea,
but the API has been exported this way, so I'm reluctant to change
it after the fact.

Would you mind to call your new functions with trailing 'l' rather
than 'r', too, to use the same naming convention, please?

Oh, btw., please make sure the patches have no trailing whitespace.
That's not really a problem, but `git am' complains about them.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]