public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Gedare Bloom <gedare@rtems.org>
To: Aditya Upadhyay <aadit0402@gmail.com>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: Importing inttypes methods
Date: Tue, 01 Aug 2017 12:10:00 -0000	[thread overview]
Message-ID: <CAC82fA1JChf0Qh9Mwoc0oK-_MCWyjiomQ3WiVci2ez5Y9R1R9A@mail.gmail.com> (raw)
In-Reply-To: <CAMZxAxcK-1=yvxL7pfvrp1FJ=rhoCeK5P47iudX2uvV3iFswUQ@mail.gmail.com>

On Tue, Aug 1, 2017 at 4:30 AM, Aditya Upadhyay <aadit0402@gmail.com> wrote:
> On Mon, Jul 31, 2017 at 3:38 PM, Corinna Vinschen <vinschen@redhat.com> wrote:
>> On Jul 30 11:41, Gedare Bloom wrote:
>>> All,
>>>
>>> It looks like to me like the str*_l functions in stdlib.h currently
>>> are actually being guarded by __GNU_VISIBLE rather than __BSD_VISIBLE.
>>> You should see if these locale functions from BSD are in glibc, if so
>>> then I believe GNU_VISIBLE is the more appropriate guard? Someone more
>>> knowledgeable on the feature test macros might comment.
>>
>> Yes, the functions are guarded with __GNU_VISIBLE, just as in glibc.
>> No, the {str,wcs}to{i,u}max_l functions are not defined in glibc at all,
>> so they should be __BSD_VISIBLE.
>>
> Do i need to modify the code of *max methods according to strtol
> method or is this ok for master ?
Aditya,

I don't quite understand your question. To rephrase Corinna's answer:
You should keep using the __BSD_VISIBLE as you have done, since the
new functions you port are not in glibc. You still need to rewrite
your code to take into consideration my other comments.

Gedare

  reply	other threads:[~2017-08-01 12:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 19:51 Aditya Upadhyay
2017-07-26 11:08 ` Corinna Vinschen
2017-07-26 12:02   ` Aditya Upadhyay
2017-07-26 21:24     ` Aditya Upadhyay
2017-07-27 12:32       ` Corinna Vinschen
2017-07-27 14:00         ` Aditya Upadhyay
2017-07-28 10:43           ` Corinna Vinschen
2017-07-28 11:02             ` Aditya Upadhyay
2017-07-28 11:40               ` Gedare Bloom
2017-07-28 13:08                 ` Corinna Vinschen
2017-07-28 14:28                   ` Gedare Bloom
2017-07-28 18:29                     ` Corinna Vinschen
2017-07-29 12:40                       ` Gedare Bloom
2017-07-29 13:57                         ` Aditya Upadhyay
2017-07-30  8:46                           ` Aditya Upadhyay
2017-07-30 15:41                             ` Gedare Bloom
2017-07-31 10:08                               ` Corinna Vinschen
2017-08-01  8:31                                 ` Aditya Upadhyay
2017-08-01 12:10                                   ` Gedare Bloom [this message]
2017-07-28 18:24               ` Joel Sherrill
2017-07-26 12:02   ` Sebastian Huber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC82fA1JChf0Qh9Mwoc0oK-_MCWyjiomQ3WiVci2ez5Y9R1R9A@mail.gmail.com \
    --to=gedare@rtems.org \
    --cc=aadit0402@gmail.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).