From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 1/4] Importing strtoimax inttypes method from FreeBSD.
Date: Fri, 11 Aug 2017 08:24:00 -0000 [thread overview]
Message-ID: <20170811082419.GM3195@calimero.vinschen.de> (raw)
In-Reply-To: <9df019b2-7915-8f72-17bf-8c85bf7b835c@embedded-brains.de>
[-- Attachment #1: Type: text/plain, Size: 2930 bytes --]
On Aug 11 08:32, Sebastian Huber wrote:
> On 02/08/17 13:04, Corinna Vinschen wrote:
>
> > On Aug 2 08:49, Aditya Upadhyay wrote:
> > > ---
> > > newlib/libc/include/inttypes.h | 12 +++
> > > newlib/libc/stdlib/Makefile.am | 1 +
> > > newlib/libc/stdlib/strtoimax.c | 167 +++++++++++++++++++++++++++++++++++++++++
> > All 4 patches applied.
> >
> > I made a few minor formatting changes in terms of whitespaces and
> > missing empty lines between functions. Please compare what I commited
> > with your local patch to see the differences.
>
> The files are not built currently. We have to regenerate the Makefile.in. I
> had problems with that using automake 1.12.2:
>
> configure.in:251: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected
> in body
> ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
> ../libtool.m4:1080: _LT_SYS_MODULE_PATH_AIX is expanded from...
> ../libtool.m4:4213: _LT_LINKER_SHLIBS is expanded from...
> ../libtool.m4:5341: _LT_LANG_C_CONFIG is expanded from...
> ../libtool.m4:141: _LT_SETUP is expanded from...
> ../libtool.m4:67: LT_INIT is expanded from...
> ../libtool.m4:106: AM_PROG_LIBTOOL is expanded from...
> configure.in:251: the top level
> configure.in:251: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected
> in body
> ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
> ../libtool.m4:4213: _LT_LINKER_SHLIBS is expanded from...
> ../libtool.m4:5341: _LT_LANG_C_CONFIG is expanded from...
> ../libtool.m4:141: _LT_SETUP is expanded from...
> ../libtool.m4:67: LT_INIT is expanded from...
> ../libtool.m4:106: AM_PROG_LIBTOOL is expanded from...
> configure.in:251: the top level
> configure.in:241: error: version mismatch. This is Automake 1.12.2,
> configure.in:241: but the definition used by this AM_INIT_AUTOMAKE
> configure.in:241: comes from Automake 1.11.6. You should recreate
> configure.in:241: aclocal.m4 with aclocal and run automake again.
I just regenerated stdlib/Makefile.in (and screwed up the log message).
> I don't know how to regenerate libc/stdio/Makefile.in using automake 1.12.2.
I'm always a bit fuzzy about this as well. Basically I cd into
either newlib/libc or newlib/libm, whatever needs a regen, then
aclocal-1.12.2 -I. -I..
autoconf-2.69
automake-1.12.2 --cygnus --no-force
This regenerates a lot of files unnecessarily, but they can be easily
reset to the current state (git checkout --) and I only keep the
Makefile.in which actually needed the regen.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-08-11 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 3:20 Aditya Upadhyay
2017-08-02 11:04 ` Corinna Vinschen
2017-08-02 13:56 ` Gedare Bloom
2017-08-02 14:06 ` Aditya Upadhyay
2017-08-11 6:32 ` Sebastian Huber
2017-08-11 7:11 ` Aditya Upadhyay
2017-08-11 8:24 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811082419.GM3195@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).