[PATCH] Fix to stop a fall-through in a switch statement

[PATCH] Fix to stop a fall-through in a switch statement

[Jordi Sanfeliu]

Hello,

The following fixes a fall-through that prevented from reading the next 
entry in the UTMP file and terminated the program with an abort().

diff --git a/newlib/libc/unix/getut.c b/newlib/libc/unix/getut.c
index c3a9b62..89ed739 100644
--- a/newlib/libc/unix/getut.c
+++ b/newlib/libc/unix/getut.c
@@ -65,6 +65,7 @@ getutid (struct utmp *id)
         case DEAD_PROCESS:
           if (id->ut_id == utmp_data.ut_id)
             return &utmp_data;
+         break;
         default:
           abort ();
         }

Thanks.

-- 
Jordi Sanfeliu
FIBRANET Network Services Provider
https://www.fibranet.cat

Re: [PATCH] Fix to stop a fall-through in a switch statement

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

On Jul 13 12:15, Jordi Sanfeliu wrote:
> Hello,
> 
> The following fixes a fall-through that prevented from reading the next
> entry in the UTMP file and terminated the program with an abort().
> 
> diff --git a/newlib/libc/unix/getut.c b/newlib/libc/unix/getut.c
> index c3a9b62..89ed739 100644
> --- a/newlib/libc/unix/getut.c
> +++ b/newlib/libc/unix/getut.c
> @@ -65,6 +65,7 @@ getutid (struct utmp *id)
>         case DEAD_PROCESS:
>           if (id->ut_id == utmp_data.ut_id)
>             return &utmp_data;
> +         break;
>         default:
>           abort ();
>         }

Your patch has whitespace problems (TABs -> space).  Just a hint
for next time, I applied and pushed it with changes for now.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]