From: Corinna Vinschen <vinschen@redhat.com>
To: Bastien Bouclet <bastien.bouclet@gmail.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] newlib: fix fseek optimization with SEEK_CUR
Date: Mon, 18 Nov 2019 10:11:00 -0000 [thread overview]
Message-ID: <20191118101153.GB3372@calimero.vinschen.de> (raw)
In-Reply-To: <20191109162804.1905160-1-bastien.bouclet@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
On Nov 9 17:28, Bastien Bouclet wrote:
> The call to fflush was invalidating the read buffer, preventing relative
> seeks to positions that would have been inside the read buffer from
> being optimized. The call to srefill would then re-read mostly the same
> data that was initially in the read buffer.
> ---
> newlib/libc/stdio/fseeko.c | 31 ++++++-------------------------
> newlib/libc/stdio64/fseeko64.c | 31 ++++++-------------------------
> 2 files changed, 12 insertions(+), 50 deletions(-)
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-18 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 16:28 Bastien Bouclet
2019-11-13 10:15 ` Corinna Vinschen
2019-11-18 10:11 ` Corinna Vinschen [this message]
2020-01-29 18:02 ` Corinna Vinschen
2019-11-13 20:36 Bastien Bouclet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118101153.GB3372@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=bastien.bouclet@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).