* [PATCH] pru: Fix memory corruption on syscall return
@ 2020-06-03 16:14 Dimitar Dimitrov
2020-07-01 20:11 ` Dimitar Dimitrov
2020-07-02 9:00 ` Corinna Vinschen
0 siblings, 2 replies; 3+ messages in thread
From: Dimitar Dimitrov @ 2020-06-03 16:14 UTC (permalink / raw)
To: newlib
In the initial code I missed one level of pointer indirection. Instead
of storing errno in impure_data, _impure_ptr was corrupted.
Only simulator is impacted. Real targets have no OS and no syscalls.
This resolves a bunch of stdio cases from the GCC testsuite:
FAIL->PASS: gcc.c-torture/execute/printf-2.c -O0 execution test
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
libgloss/pru/syscalls.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/libgloss/pru/syscalls.S b/libgloss/pru/syscalls.S
index 8ed7601a4..3ad0d9215 100644
--- a/libgloss/pru/syscalls.S
+++ b/libgloss/pru/syscalls.S
@@ -42,6 +42,7 @@ __SC_ret:
/* Invert return code and store to errno (first int in _impure_ptr). */
rsb r14, r14, 0
ldi32 r1, _impure_ptr
+ lbbo r1, r1, 0, 4
sbbo r14, r1, 0, 4
/* Return -1 (for both int32_t or int64_t). */
fill r14, 8
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pru: Fix memory corruption on syscall return
2020-06-03 16:14 [PATCH] pru: Fix memory corruption on syscall return Dimitar Dimitrov
@ 2020-07-01 20:11 ` Dimitar Dimitrov
2020-07-02 9:00 ` Corinna Vinschen
1 sibling, 0 replies; 3+ messages in thread
From: Dimitar Dimitrov @ 2020-07-01 20:11 UTC (permalink / raw)
To: newlib
On сряда, 3 юни 2020 г. 19:14:22 EEST Dimitar Dimitrov wrote:
> In the initial code I missed one level of pointer indirection. Instead
> of storing errno in impure_data, _impure_ptr was corrupted.
>
> Only simulator is impacted. Real targets have no OS and no syscalls.
>
> This resolves a bunch of stdio cases from the GCC testsuite:
> FAIL->PASS: gcc.c-torture/execute/printf-2.c -O0 execution test
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> libgloss/pru/syscalls.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libgloss/pru/syscalls.S b/libgloss/pru/syscalls.S
> index 8ed7601a4..3ad0d9215 100644
> --- a/libgloss/pru/syscalls.S
> +++ b/libgloss/pru/syscalls.S
> @@ -42,6 +42,7 @@ __SC_ret:
> /* Invert return code and store to errno (first int in _impure_ptr). */
> rsb r14, r14, 0
> ldi32 r1, _impure_ptr
> + lbbo r1, r1, 0, 4
> sbbo r14, r1, 0, 4
> /* Return -1 (for both int32_t or int64_t). */
> fill r14, 8
Gentle ping
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pru: Fix memory corruption on syscall return
2020-06-03 16:14 [PATCH] pru: Fix memory corruption on syscall return Dimitar Dimitrov
2020-07-01 20:11 ` Dimitar Dimitrov
@ 2020-07-02 9:00 ` Corinna Vinschen
1 sibling, 0 replies; 3+ messages in thread
From: Corinna Vinschen @ 2020-07-02 9:00 UTC (permalink / raw)
To: newlib
On Jun 3 19:14, Dimitar Dimitrov wrote:
> In the initial code I missed one level of pointer indirection. Instead
> of storing errno in impure_data, _impure_ptr was corrupted.
>
> Only simulator is impacted. Real targets have no OS and no syscalls.
>
> This resolves a bunch of stdio cases from the GCC testsuite:
> FAIL->PASS: gcc.c-torture/execute/printf-2.c -O0 execution test
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> libgloss/pru/syscalls.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libgloss/pru/syscalls.S b/libgloss/pru/syscalls.S
> index 8ed7601a4..3ad0d9215 100644
> --- a/libgloss/pru/syscalls.S
> +++ b/libgloss/pru/syscalls.S
> @@ -42,6 +42,7 @@ __SC_ret:
> /* Invert return code and store to errno (first int in _impure_ptr). */
> rsb r14, r14, 0
> ldi32 r1, _impure_ptr
> + lbbo r1, r1, 0, 4
> sbbo r14, r1, 0, 4
> /* Return -1 (for both int32_t or int64_t). */
> fill r14, 8
> --
> 2.20.1
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-02 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 16:14 [PATCH] pru: Fix memory corruption on syscall return Dimitar Dimitrov
2020-07-01 20:11 ` Dimitar Dimitrov
2020-07-02 9:00 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).