From: Corinna Vinschen <vinschen@redhat.com>
To: Eshan dhawan <eshandhawan51@gmail.com>
Cc: newlib@sourceware.org, joel@rtems.com
Subject: Re: [PATCH] Added FTW.H Methods
Date: Thu, 13 Aug 2020 10:16:51 +0200 [thread overview]
Message-ID: <20200813081651.GU53219@calimero.vinschen.de> (raw)
In-Reply-To: <20200812213852.26096-1-eshandhawan51@gmail.com>
On Aug 13 03:08, Eshan dhawan via Newlib wrote:
> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
> ---
> newlib/configure.host | 2 +-
> newlib/libc/include/ftw.h | 64 ++++++++++++++
> newlib/libc/posix/Makefile.am | 2 +-
> newlib/libc/posix/ftw.c | 36 ++++++++
> newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
> 5 files changed, 256 insertions(+), 2 deletions(-)
> create mode 100644 newlib/libc/include/ftw.h
> create mode 100644 newlib/libc/posix/ftw.c
> create mode 100644 newlib/libc/posix/nftw.c
Why do we need _FTW_ENABLE_?
What do we need the foo64 variants for? WHile newlib defines
_LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used
anywhere else in newlib itself.
Also, there's a ftw/nftw implementation in Cygwin already. Did you
check it for inclusion into newlib, or to drop the Cygwin version in
favor of a new newlib versions? We could at least share a common
header, but then we will have to use the flag values already used in
the Cygwin implementation for backward compatibility.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
next prev parent reply other threads:[~2020-08-13 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 21:38 Eshan dhawan
2020-08-13 8:16 ` Corinna Vinschen [this message]
2020-08-13 13:11 ` Joel Sherrill
2020-08-17 9:42 ` Corinna Vinschen
2020-08-17 10:40 ` Eshan Dhawan
2020-08-17 15:38 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813081651.GU53219@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=eshandhawan51@gmail.com \
--cc=joel@rtems.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).