From: Joel Sherrill <joel@rtems.org>
To: Newlib <newlib@sourceware.org>,
Eshan dhawan <eshandhawan51@gmail.com>,
joel@rtems.com
Cc: Corinna Vinschen <vinschen@redhat.com>
Subject: Re: [PATCH] Added FTW.H Methods
Date: Thu, 13 Aug 2020 08:11:31 -0500 [thread overview]
Message-ID: <CAF9ehCW9GHujePLSL7Ci0tiMykOrgq556fWQLNg=wT1xDi0ptw@mail.gmail.com> (raw)
In-Reply-To: <20200813081651.GU53219@calimero.vinschen.de>
On Thu, Aug 13, 2020 at 3:17 AM Corinna Vinschen via Newlib <
newlib@sourceware.org> wrote:
> On Aug 13 03:08, Eshan dhawan via Newlib wrote:
> > Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
> > ---
> > newlib/configure.host | 2 +-
> > newlib/libc/include/ftw.h | 64 ++++++++++++++
> > newlib/libc/posix/Makefile.am | 2 +-
> > newlib/libc/posix/ftw.c | 36 ++++++++
> > newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
> > 5 files changed, 256 insertions(+), 2 deletions(-)
> > create mode 100644 newlib/libc/include/ftw.h
> > create mode 100644 newlib/libc/posix/ftw.c
> > create mode 100644 newlib/libc/posix/nftw.c
>
> Why do we need _FTW_ENABLE_?
>
> What do we need the foo64 variants for? WHile newlib defines
> _LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used
> anywhere else in newlib itself.
>
> Also, there's a ftw/nftw implementation in Cygwin already. Did you
> check it for inclusion into newlib, or to drop the Cygwin version in
> favor of a new newlib versions? We could at least share a common
> header, but then we will have to use the flag values already used in
> the Cygwin implementation for backward compatibility.
>
We went straight to *BSD for implementations and didn't look at Cygwin.
I've asked Eshan to replace the implementation with the Cygwin one.
Hopefully that's easy and allows one more piece of shared software.
--joel
>
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
>
>
next prev parent reply other threads:[~2020-08-13 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 21:38 Eshan dhawan
2020-08-13 8:16 ` Corinna Vinschen
2020-08-13 13:11 ` Joel Sherrill [this message]
2020-08-17 9:42 ` Corinna Vinschen
2020-08-17 10:40 ` Eshan Dhawan
2020-08-17 15:38 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF9ehCW9GHujePLSL7Ci0tiMykOrgq556fWQLNg=wT1xDi0ptw@mail.gmail.com' \
--to=joel@rtems.org \
--cc=eshandhawan51@gmail.com \
--cc=joel@rtems.com \
--cc=newlib@sourceware.org \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).