From: Joel Sherrill <joel@rtems.org>
To: newlib@sourceware.org
Subject: [PATCH newlib 0/1] sys/signal.h needs sys/_intsup.h
Date: Wed, 25 Aug 2021 14:12:44 -0500 [thread overview]
Message-ID: <20210825191245.30049-1-joel@rtems.org> (raw)
Hi
The recent addition of the sig2str block of code for definitions and
prototypes resulted in the following one line program not compiling
for RTEMS targets:
#include <sys/signal.h>
Turned out that __STDINT_EXP used to conditionalize the definition
of SIG2STR_MAX isn't defined unless <sys/_intsup.h> is included.
I guess the test code got lucky.
It's a simple patch that needed more background and investigation
than code.
Is it safe to assume that including each POSIX and Standard C Library file
independently should compile? If so, I will file a ticket to at least at
those to the RTEMS compile only tests like the ones we have that check
a method can be used per the specific includes in the POSIX specification.
Sorry this slipped through.
--joel
Joel Sherrill (1):
sys/signal.h: <sys/_intsup.h> is needed for __STDINT_EXP
newlib/libc/include/sys/signal.h | 4 ++++
1 file changed, 4 insertions(+)
--
2.24.4
next reply other threads:[~2021-08-25 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 19:12 Joel Sherrill [this message]
2021-08-25 19:12 ` [PATCH newlib 1/1] sys/signal.h: <sys/_intsup.h> is needed for __STDINT_EXP Joel Sherrill
[not found] ` <DM3P110MB052286CA15662F2A669975A29AC69@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-08-25 19:48 ` Fw: [PATCH newlib 0/1] sys/signal.h needs sys/_intsup.h C Howland
2021-08-26 23:28 ` Joel Sherrill
2021-08-27 10:15 ` Corinna Vinschen
2021-08-27 13:47 ` Joel Sherrill
[not found] ` <DM3P110MB05221A305E6DAF45A77CCCAA9AC89@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-08-27 15:12 ` C Howland
2021-08-27 16:16 ` Joel Sherrill
2021-08-27 17:52 ` C Howland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825191245.30049-1-joel@rtems.org \
--to=joel@rtems.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).