From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: Fw: [PATCH newlib 0/1] sys/signal.h needs sys/_intsup.h
Date: Fri, 27 Aug 2021 12:15:57 +0200 [thread overview]
Message-ID: <YSi7XWDdv8fJ4u0l@calimero.vinschen.de> (raw)
In-Reply-To: <CAF9ehCWrrEhBjLgKQ3Gg3RTcJ3jcmRUXPS+koiwghgEbVkFJaA@mail.gmail.com>
On Aug 26 18:28, Joel Sherrill wrote:
> We recently added this to sys/signal.h:
>
> #if __STDINT_EXP(INT_MAX) > 0x7fff
> #define SIG2STR_MAX (sizeof("RTMAX+") + sizeof("4294967295") - 1)
> #else
> #define SIG2STR_MAX (sizeof("RTMAX+") + sizeof("65535") - 1)
> #endif
>
> And -ffreestanding breaks that. I see two solutions:
>
> (1) Add __STDINT_EXP to gcc's stdint-gcc.h
> (2) Switch that #if to something else
>
> I think something like this is an OK substitute works equivalently:
>
> #if __SIZEOF_INT__ > 2
or even __SIZEOF_INT__ >= 4 to be extra *extra* paranoid, but yeah,
sure, go ahead. The commmit message should just briefly explain the
freestanding implementation issue.
Corinna
next prev parent reply other threads:[~2021-08-27 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 19:12 Joel Sherrill
2021-08-25 19:12 ` [PATCH newlib 1/1] sys/signal.h: <sys/_intsup.h> is needed for __STDINT_EXP Joel Sherrill
[not found] ` <DM3P110MB052286CA15662F2A669975A29AC69@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-08-25 19:48 ` Fw: [PATCH newlib 0/1] sys/signal.h needs sys/_intsup.h C Howland
2021-08-26 23:28 ` Joel Sherrill
2021-08-27 10:15 ` Corinna Vinschen [this message]
2021-08-27 13:47 ` Joel Sherrill
[not found] ` <DM3P110MB05221A305E6DAF45A77CCCAA9AC89@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-08-27 15:12 ` C Howland
2021-08-27 16:16 ` Joel Sherrill
2021-08-27 17:52 ` C Howland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSi7XWDdv8fJ4u0l@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).