From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: [PATCH] newlib: undefine _FORTIFY_SOURCE
Date: Mon, 8 Nov 2021 21:56:56 -0500 [thread overview]
Message-ID: <20211109025656.26127-1-vapier@gentoo.org> (raw)
Some distros enable _FORTIFY_SOURCE by default which upsets building
newlib which itself implements the logic for this define. For example,
building gets.c fails because the includes set up a gets() macro which
expands in the definition.
Since newlib isn't prepared to build itself with _FORTIFY_SOURCE, and
it's not clear if it's even useful, disable it when building the code.
This also matches what glibc is doing.
---
newlib/configure.host | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/configure.host b/newlib/configure.host
index e737f73f5f75..cb0c5d01f874 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -54,7 +54,7 @@
# have_init_fini have init/fini ("yes" or "no", set to "yes" by default)
# noinclude list of include files to not install
-newlib_cflags="-D_COMPILING_NEWLIB"
+newlib_cflags="-D_COMPILING_NEWLIB -U_FORTIFY_SOURCE"
libm_machine_dir=
machine_dir=
shared_machine_dir=
--
2.33.0
next reply other threads:[~2021-11-09 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 2:56 Mike Frysinger [this message]
2021-11-09 2:59 ` [PATCH alternative] newlib: ignore _FORTIFY_SOURCE when building newlib Mike Frysinger
2021-11-12 10:28 ` Corinna Vinschen
2021-11-09 3:15 ` [PATCH] newlib: undefine _FORTIFY_SOURCE Keith Packard
2021-11-09 11:41 ` Corinna Vinschen
2021-11-10 2:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109025656.26127-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).