From: Keith Packard <keithp@keithp.com>
To: Mike Frysinger <vapier@gentoo.org>, newlib@sourceware.org
Subject: Re: [PATCH] newlib: undefine _FORTIFY_SOURCE
Date: Mon, 08 Nov 2021 19:15:31 -0800 [thread overview]
Message-ID: <87tugmm33g.fsf@keithp.com> (raw)
In-Reply-To: <20211109025656.26127-1-vapier@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
Mike Frysinger <vapier@gentoo.org> writes:
> Since newlib isn't prepared to build itself with _FORTIFY_SOURCE, and
> it's not clear if it's even useful, disable it when building the code.
It is useful; I've caught a few library bugs when I turned this on for
picolibc. Fixing newlib to handle -D_FORTIFY_SOURCE could probably start
with the patches I did in picolibc, which mostly just #undef the various
mem and str functions before defining them.
General code:
https://github.com/picolibc/picolibc/commit/c2c593afa60b64bff0a958ad930e0336463db5bf
Arm specific code:
https://github.com/picolibc/picolibc/commit/b3946840fb3a677125bc9232ca93ea7533375188
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-11-09 3:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 2:56 Mike Frysinger
2021-11-09 2:59 ` [PATCH alternative] newlib: ignore _FORTIFY_SOURCE when building newlib Mike Frysinger
2021-11-12 10:28 ` Corinna Vinschen
2021-11-09 3:15 ` Keith Packard [this message]
2021-11-09 11:41 ` [PATCH] newlib: undefine _FORTIFY_SOURCE Corinna Vinschen
2021-11-10 2:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tugmm33g.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=newlib@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).