From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Cc: jon.turney@dronecode.org.uk
Subject: [PATCH 3/3] newlib: fix cygwin -I path
Date: Thu, 27 Jan 2022 19:33:16 -0500 [thread overview]
Message-ID: <20220128003316.22356-3-vapier@gentoo.org> (raw)
In-Reply-To: <20220128003316.22356-1-vapier@gentoo.org>
This code snippet assumed it was only ever run in the top configure
script where srcdir would point to newlib/ which is parallel to the
winsup/ tree. This is incorrect for all of the subdir configure
scripts leading to bad -I flags in $(CC). Switch it over to the
new abs_newlib_basedir which should work in all subdirs.
---
newlib/configure.host | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/configure.host b/newlib/configure.host
index ca6b46f03e09..bf4a555e6da7 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -641,7 +641,7 @@ esac
case "${host}" in
*-*-cygwin*)
- test -z "$cygwin_srcdir" && cygwin_srcdir=`cd ${srcdir}/../winsup/cygwin; pwd`
+ test -z "$cygwin_srcdir" && cygwin_srcdir="${abs_newlib_basedir}/../winsup/cygwin"
export cygwin_srcdir
default_newlib_io_c99_formats="yes"
default_newlib_io_long_long="yes"
--
2.34.1
next prev parent reply other threads:[~2022-01-28 0:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 0:33 [PATCH 1/3] newlib: export abs_newlib_basedir for all subdirs Mike Frysinger
2022-01-28 0:33 ` [PATCH 2/3] newlib: use abs_newlib_basedir for -I paths Mike Frysinger
2022-01-28 0:33 ` Mike Frysinger [this message]
2022-01-31 13:16 ` [PATCH 1/3] newlib: export abs_newlib_basedir for all subdirs Corinna Vinschen
2022-02-01 3:10 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128003316.22356-3-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=jon.turney@dronecode.org.uk \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).