From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: Re: [PATCH 1/3] newlib: export abs_newlib_basedir for all subdirs
Date: Mon, 31 Jan 2022 22:10:25 -0500 [thread overview]
Message-ID: <YfikodKz/MgM65JA@vapier> (raw)
In-Reply-To: <YffhO2rpDrW03oPO@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On 31 Jan 2022 14:16, Corinna Vinschen wrote:
> On Jan 27 19:33, Mike Frysinger wrote:
> > When using the top-level configure script but subdir Makefiles, the
> > newlib_basedir value gets a bit out of sync: it's relative to where
> > configure lives, not where the Makefile lives. Move the abs setting
> > from the top-level configure script into acinclude.m4 so we can rely
> > on it being available everywhere. Although this commit doesn't use
> > it anywhere, just lays the groundwork.
>
> Patchset looks ok to me. Would you mind to send patchsets consisting
> of more than a single patch with a cover-letter? It's just easier
> to discusss the entire patchset vs. discussing single patches.
sure, if you prefer
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-02-01 3:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 0:33 Mike Frysinger
2022-01-28 0:33 ` [PATCH 2/3] newlib: use abs_newlib_basedir for -I paths Mike Frysinger
2022-01-28 0:33 ` [PATCH 3/3] newlib: fix cygwin -I path Mike Frysinger
2022-01-31 13:16 ` [PATCH 1/3] newlib: export abs_newlib_basedir for all subdirs Corinna Vinschen
2022-02-01 3:10 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfikodKz/MgM65JA@vapier \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).