public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: [PATCH 1/2] newlib: fix preprocessor checks
Date: Fri, 28 Jan 2022 05:23:54 -0500	[thread overview]
Message-ID: <20220128102355.10213-1-vapier@gentoo.org> (raw)
In-Reply-To: <171dc9cb-6b2c-ead3-1c55-27fadb33220f@gmail.com>

Restore the call to AC_NO_EXECUTABLES -- I naively assumed in commit
2e9aa5f56cc26a411014a7f788423c670cfb5646 ("newlib: update preprocessor
configure checks") that checking for a preprocessor would not involve
linking code.  Unfortunately, autoconf will implicitly check that the
compiler "works" before allowing it to be used, and that involves a
link test, and that fails because newlib provides the C library which
is needed to pass a link test.

There is some code in NEWLIB_CONFIGURE specifically to help mitigate
these, but it's not kicking in here for some reason, so let's just add
the AC_NO_EXECUTABLES call back until we can unwind that custom logic.

Additionally, we have to call AC_PROG_CPP explicitly.  This was being
invoked later on, but only in the use_libtool=yes codepath, and that
is almost never enabled.
---
 newlib/libc/configure    | 1206 +++++++++++++++++++++-----------------
 newlib/libc/configure.ac |    2 +
 newlib/libm/configure    | 1128 +++++++++++++++++++----------------
 newlib/libm/configure.ac |    2 +
 4 files changed, 1285 insertions(+), 1053 deletions(-)

diff --git a/newlib/libc/configure.ac b/newlib/libc/configure.ac
index 5d4dc7bf5600..4a0160a57d80 100644
--- a/newlib/libc/configure.ac
+++ b/newlib/libc/configure.ac
@@ -45,7 +45,9 @@ AC_ARG_ENABLE(newlib-retargetable-locking,
  esac],[newlib_retargetable_locking=no])
 AM_CONDITIONAL(NEWLIB_RETARGETABLE_LOCKING, test x$newlib_retargetable_locking = xyes)
 
+AC_NO_EXECUTABLES
 NEWLIB_CONFIGURE(..)
+AC_PROG_CPP
 
 AM_CONDITIONAL(NEWLIB_NANO_MALLOC, test x$newlib_nano_malloc = xyes)
 
diff --git a/newlib/libm/configure.ac b/newlib/libm/configure.ac
index e4611ed846dd..a03ea3872bd5 100644
--- a/newlib/libm/configure.ac
+++ b/newlib/libm/configure.ac
@@ -16,7 +16,9 @@ AM_CONDITIONAL(NEWLIB_HW_FP, test x$newlib_hw_fp = xtrue)
 dnl Can't be done in NEWLIB_CONFIGURE because that confuses automake. 
 AC_CONFIG_AUX_DIR(../..)
 
+AC_NO_EXECUTABLES
 NEWLIB_CONFIGURE(..)
+AC_PROG_CPP
 
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
-- 
2.34.1


       reply	other threads:[~2022-01-28 10:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171dc9cb-6b2c-ead3-1c55-27fadb33220f@gmail.com>
2022-01-28 10:23 ` Mike Frysinger [this message]
2022-01-28 10:23   ` [PATCH 2/2] newlib: add AC_CACHE_CHECK sugar around " Mike Frysinger
2022-01-31 14:20     ` Corinna Vinschen
2022-01-31 14:18   ` [PATCH 1/2] newlib: fix " Corinna Vinschen
     [not found] ` <YfPDA/LVL745V+02@vapier>
2022-01-28 16:36   ` nds broken by recent patches Jeff Law
2022-01-28 21:54     ` Jeff Law
2022-01-28 23:32       ` Stafford Horne
2022-01-29  0:58         ` Jeff Law
2022-01-29  2:12           ` Stafford Horne
2022-01-29  3:28             ` Jeff Law
2022-01-29  5:15       ` Mike Frysinger
2022-01-29  5:12     ` [PATCH/committed] libgloss: update Makefile regen rules for merged arches Mike Frysinger
2022-01-29  5:13     ` nds broken by recent patches Mike Frysinger
2022-01-31 14:34       ` R. Diez
2022-02-01 17:25       ` Jeff Law
2022-02-02 10:23         ` Mike Frysinger
2022-02-02 20:59           ` Jeff Law
2022-02-03 16:11       ` libgloss multilib installs broken [was nds broken by recent patches] Jeff Law
2022-02-04  5:45         ` Mike Frysinger
2022-02-07 15:40           ` Jeff Law
2022-02-04  8:55         ` [PATCH] libgloss: restore multilib settings in subdir makefiles Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128102355.10213-1-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).