From: Mike Frysinger <vapier@gentoo.org>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: newlib@sourceware.org
Subject: Re: nds broken by recent patches
Date: Sat, 29 Jan 2022 00:15:15 -0500 [thread overview]
Message-ID: <YfTNY8A19wrH5FFk@vapier> (raw)
In-Reply-To: <c2154c6c-4969-b231-c72c-75bc1af34f9d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On 28 Jan 2022 14:54, Jeff Law wrote:
> On 1/28/2022 9:36 AM, Jeff Law wrote:
> > For example, someone mucked up the compiler for or1k-elf at the same
> > time you're doing your refactoring. Now I've got a patch to fix the
> > compiler ICE, *but* I'm also getting a crap-ton of new testsuite
> > failures in the testsuite due to missing _init/_fini symbols. I don't
> > know yet if that's a newlib issue or something else mucked up on the
> > compiler side.
>
> I think I've tracked this done. The change to internalize
> HAVE_INITFINI_ARRAY wasn't complete. It missed newlib. Affects
> aarch64, arm, or1k and cris -elf ports. I don't test for former pair,
> but I do test the latter pair. or1k and cris fail differently.
> or1k-elf code fails to link, while cris-elf fails a few tests that rely
> on ctor/dtor support.
thanks ... the expectation was that things outside of newlib weren't
relying on this, but i think it's prob OK for libgloss to. not great,
but not entirely unreasonable. not sure what you meant by "it missed
newlib" as your fix only touches libgloss. assuming that was a thinko.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-29 5:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171dc9cb-6b2c-ead3-1c55-27fadb33220f@gmail.com>
2022-01-28 10:23 ` [PATCH 1/2] newlib: fix preprocessor checks Mike Frysinger
2022-01-28 10:23 ` [PATCH 2/2] newlib: add AC_CACHE_CHECK sugar around " Mike Frysinger
2022-01-31 14:20 ` Corinna Vinschen
2022-01-31 14:18 ` [PATCH 1/2] newlib: fix " Corinna Vinschen
[not found] ` <YfPDA/LVL745V+02@vapier>
2022-01-28 16:36 ` nds broken by recent patches Jeff Law
2022-01-28 21:54 ` Jeff Law
2022-01-28 23:32 ` Stafford Horne
2022-01-29 0:58 ` Jeff Law
2022-01-29 2:12 ` Stafford Horne
2022-01-29 3:28 ` Jeff Law
2022-01-29 5:15 ` Mike Frysinger [this message]
2022-01-29 5:12 ` [PATCH/committed] libgloss: update Makefile regen rules for merged arches Mike Frysinger
2022-01-29 5:13 ` nds broken by recent patches Mike Frysinger
2022-01-31 14:34 ` R. Diez
2022-02-01 17:25 ` Jeff Law
2022-02-02 10:23 ` Mike Frysinger
2022-02-02 20:59 ` Jeff Law
2022-02-03 16:11 ` libgloss multilib installs broken [was nds broken by recent patches] Jeff Law
2022-02-04 5:45 ` Mike Frysinger
2022-02-07 15:40 ` Jeff Law
2022-02-04 8:55 ` [PATCH] libgloss: restore multilib settings in subdir makefiles Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfTNY8A19wrH5FFk@vapier \
--to=vapier@gentoo.org \
--cc=jeffreyalaw@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).