From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: newlib@sourceware.org
Subject: Re: [PATCH v5] newlib: libc: Fix crash on fprintf to a wide-oriented stream.
Date: Fri, 10 Nov 2023 00:36:02 +0900 [thread overview]
Message-ID: <20231110003602.909efa12752d9365403db70a@nifty.ne.jp> (raw)
In-Reply-To: <ZUzVZTd6SuD5W+7R@calimero.vinschen.de>
On Thu, 9 Nov 2023 13:49:41 +0100
Corinna Vinschen wrote:
> On Nov 9 19:26, Takashi Yano wrote:
> > On Thu, 9 Nov 2023 11:08:03 +0100
> > Corinna Vinschen wrote:
> > > Looks good, please push.
> >
> > Thanks. Should this also be applied to cygwin-3_4-branch?
>
> Tricky question. It's a bugfix, yeah, but a bugfix for an undefined
> situation. And it's also a behavioral change. So, from my POV we
> shouldn't backport it.
I see. I'll push it only for master branch.
> But if you have another POV, we can discuss it. It occured to me that
> you didn't mention where the testcase is coming from. Was that a
> real-world problem? If so, where and in which circumstances?
No. It was discovered by an accidental mistake while writing
a test case for another problem.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2023-11-09 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 21:48 Takashi Yano
2023-11-09 10:08 ` Corinna Vinschen
2023-11-09 10:26 ` Takashi Yano
2023-11-09 12:49 ` Corinna Vinschen
2023-11-09 15:36 ` Takashi Yano [this message]
2023-11-10 10:18 ` Christophe Lyon
2023-11-10 11:34 ` Takashi Yano
2023-11-10 13:33 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110003602.909efa12752d9365403db70a@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).