public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Martin Young <martin.y@somniumtech.com>, newlib@sourceware.org
Subject: Re: [PATCH][MSP430] Fix return code error in simulator implemenations of write.c.
Date: Fri, 26 May 2017 10:37:00 -0000	[thread overview]
Message-ID: <325261e1-2f1f-d00b-fbc1-673a65226fbb@redhat.com> (raw)
In-Reply-To: <CAAcP3OMWi+iQRwBjfMhrMQ0yTd_emX=VatPOvJ8YB2UodgRPmQ@mail.gmail.com>

Hi Martin,

> In the MSP430 simulator implementation of write() in write.c the wrong
> local is used as the return code (it's returning the result of the
> last invocation of write_chunk() (variable c) rather than the
> aggregate write size (variable rv). This causes issues for users of
> write().
> 
> Patch included as attachment to avoid whitespace issues.

Thanks very much for reporting this problem, and for providing a fix.
I have checked your patch in, so the write() function should work
properly from now on.

Cheers
  Nick


      reply	other threads:[~2017-05-26 10:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26  7:50 Martin Young
2017-05-26 10:37 ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=325261e1-2f1f-d00b-fbc1-673a65226fbb@redhat.com \
    --to=nickc@redhat.com \
    --cc=martin.y@somniumtech.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).