[PATCH][MSP430] Fix return code error in simulator implemenations of write.c.

[PATCH][MSP430] Fix return code error in simulator implemenations of write.c.

[Martin Young]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hello,

In the MSP430 simulator implementation of write() in write.c the wrong
local is used as the return code (it's returning the result of the
last invocation of write_chunk() (variable c) rather than the
aggregate write size (variable rv). This causes issues for users of
write().

Patch included as attachment to avoid whitespace issues.

I do do not have the ability to apply patch this myself.

Regards,
-Martin.

[-- Attachment #2: rc.patch --]
[-- Type: application/octet-stream, Size: 687 bytes --]

From 597e1725a807b0025b774a63b798734c9e2102f0 Mon Sep 17 00:00:00 2001
From: Martin <martin.y@somniumtech.com>
Date: Wed, 1 Mar 2017 10:07:40 +0000
Subject: [PATCH] Fix return code error in simulator implemenations of write.c.
 Case #5073

---
 newlib.subtree/libgloss/msp430/write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib.subtree/libgloss/msp430/write.c b/newlib.subtree/libgloss/msp430/write.c
index 0c01098..3a5a9f8 100644
--- a/newlib.subtree/libgloss/msp430/write.c
+++ b/newlib.subtree/libgloss/msp430/write.c
@@ -55,5 +55,5 @@ write (int fd, char *buf, int len)
       len -= l;
       buf += l;
     }
-  return c;
+  return rv;
 }
-- 
2.9.3

Re: [PATCH][MSP430] Fix return code error in simulator implemenations of write.c.

[Nick Clifton]

Hi Martin,

> In the MSP430 simulator implementation of write() in write.c the wrong
> local is used as the return code (it's returning the result of the
> last invocation of write_chunk() (variable c) rather than the
> aggregate write size (variable rv). This causes issues for users of
> write().
> 
> Patch included as attachment to avoid whitespace issues.

Thanks very much for reporting this problem, and for providing a fix.
I have checked your patch in, so the write() function should work
properly from now on.

Cheers
  Nick