Re: [PATCH] update to Unicode 14.0

[Thomas Wolff <towo@towo.net>]

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]


Am 15.11.2021 um 17:12 schrieb Corinna Vinschen:
> On Nov 15 15:22, Thomas Wolff wrote:
>> Am 15.11.2021 um 14:06 schrieb Corinna Vinschen:
>>> On Nov 11 21:32, Thomas Wolff wrote:
>>>> Unicode update patch attached.
>>>> Responses to previous comments:
>>>>> wouldn't it make sense to remove the temporary downloaded files like
>>>>> libc/ctype/UnicodeData.txt, etc?
>>>>> Either automatically after creating the generated files
>>>> Maybe. I didn't implement it, like in my other projects (mintty, mined), as
>>>> it causes redundant multiple downloads during development.
>>>>> or in a matching MAINTAINERCLEANFILES variable in Makefile.am?
>>>> I had looked into it but there isn't such a variable yet and I'm not
>>>> familiar with automake/conv stuff, so feel free to add if suitable.
>>>>> Also, maybe it makes sense to add these temporary files to the .gitignore file?
>>>> I'm not in favour of the .gitignore idea as its only purpose seems to be to
>>>> smooth out effects of `git add *`-like check-ins, which I think shouldn't be
>>>> done anyway; I feel the concept encourages sloppy repository management.
>>>> But again, this isn't my project so feel free to adjust the build.
>>> It's not my project either, it's a collaborative effort.  So you don't have any other idea to fix this issue?
>> To be honest, I don't really understand the issue. So the files stay hanging
>> around for someone who builds the update. What's the problem?
> git status, git rebase etc. will list them as untracked files, which is
> annoying.  So either there's a simple way to remove the files or they
> should go to .gitignore.
OK, patch attached.
Thomas

>> I'm willing to
>> fix whatever doesn't fit.
>> Thomas
> Thanks,
> Corinna
>

[-- Attachment #2: 0001-cleanup-Unicode-data-files-after-generating-updated-.patch --]
[-- Type: text/plain, Size: 1525 bytes --]

From c47695f330e7baf5200d10e5043884a70fc17743 Mon Sep 17 00:00:00 2001
From: Thomas Wolff <towo@towo.net>
Date: Mon, 15 Nov 2021 00:00:00 +0100
Subject: [PATCH] cleanup Unicode data files after generating updated tables

---
 newlib/libc/Makefile.unidata | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/newlib/libc/Makefile.unidata b/newlib/libc/Makefile.unidata
index c85c428f2..d0590a75b 100644
--- a/newlib/libc/Makefile.unidata
+++ b/newlib/libc/Makefile.unidata
@@ -1,11 +1,31 @@
+#############################################################################
 # Generate Unicode data tables for string/wcwidth and ctype/??w*
+
+unicode-update: unidata cleanup
+
+#############################################################################
+# Clean up downloaded files
+
+cleanup:
+	rm ctype/UnicodeData.txt
+	rm string/Blocks.txt
+	rm string/EastAsianWidth.txt
+	rm string/UnicodeData.txt
+	rm string/uniset.tar.gz
+
+#############################################################################
 # Download Unicode data files
+
 unidata:
 	cd string; ./mkunidata -u
 	cd ctype; ./mkunidata -u
 
-# Generate Unicode data tables for string/wcwidth and ctype/??w*
+#############################################################################
 # Use installed Unicode data files from package unicode-ucd
+
 unidata-local:
 	cd string; ./mkunidata -i
 	cd ctype; ./mkunidata -i
+
+#############################################################################
+# end
-- 
2.33.0