From: Thomas Wolff <towo@towo.net>
To: newlib@sourceware.org
Subject: Re: [PATCH] update to Unicode 14.0
Date: Mon, 15 Nov 2021 15:22:40 +0100 [thread overview]
Message-ID: <673a19c1-1846-aa70-51b0-8ff1c68caecd@towo.net> (raw)
In-Reply-To: <YZJbOf+MFA2z7A1S@calimero.vinschen.de>
Am 15.11.2021 um 14:06 schrieb Corinna Vinschen:
> On Nov 11 21:32, Thomas Wolff wrote:
>> Unicode update patch attached.
>> Responses to previous comments:
>>> wouldn't it make sense to remove the temporary downloaded files like
>>> libc/ctype/UnicodeData.txt, etc?
>>> Either automatically after creating the generated files
>> Maybe. I didn't implement it, like in my other projects (mintty, mined), as
>> it causes redundant multiple downloads during development.
>>> or in a matching MAINTAINERCLEANFILES variable in Makefile.am?
>> I had looked into it but there isn't such a variable yet and I'm not
>> familiar with automake/conv stuff, so feel free to add if suitable.
>>> Also, maybe it makes sense to add these temporary files to the .gitignore file?
>> I'm not in favour of the .gitignore idea as its only purpose seems to be to
>> smooth out effects of `git add *`-like check-ins, which I think shouldn't be
>> done anyway; I feel the concept encourages sloppy repository management.
>> But again, this isn't my project so feel free to adjust the build.
> It's not my project either, it's a collaborative effort. So you don't have any other idea to fix this issue?
To be honest, I don't really understand the issue. So the files stay
hanging around for someone who builds the update. What's the problem?
I'm willing to fix whatever doesn't fit.
Thomas
next prev parent reply other threads:[~2021-11-15 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 20:32 Thomas Wolff
2021-11-15 13:06 ` Corinna Vinschen
2021-11-15 14:22 ` Thomas Wolff [this message]
2021-11-15 16:12 ` Corinna Vinschen
2021-11-15 20:45 ` Thomas Wolff
2021-11-16 10:40 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=673a19c1-1846-aa70-51b0-8ff1c68caecd@towo.net \
--to=towo@towo.net \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).