public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: Re: [PATCH] build: Avoid length() GNU awk extension
Date: Wed, 9 Mar 2022 10:02:59 +0100	[thread overview]
Message-ID: <395c086f-f51b-d4c1-5b4a-4df0e8cad273@embedded-brains.de> (raw)
In-Reply-To: <YihrS9u/4oDnYKyB@vapier>

On 09/03/2022 09:54, Mike Frysinger wrote:
> On 09 Mar 2022 08:31, Sebastian Huber wrote:
>> Other awk implementations such as mawk do not support the length() function.
> those awk implementations are not POSIX compliant.  length() is
> *not*  a GNU extension.  you can see it clearly defined in POSIX:
> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/awk.html#tag_20_06_13_13

Ok, it is defined by POSIX, I will adjust the commit message.

> 
> that said, mawk does support length(), and has since at least 2008 in
> the 1.3.3 release.  i stopped looking back further in the history.
> 
> so you're going to have to provide a bit more info as to what you're
> trying to do here, and what tools & versions exactly you're using.

I received an error report from someone else which regularly builds 
Newlib and this use of awk broke the build. I don't know the exact 
version of mawk which was used.

Independent of the POSIX compliance of the existing code I think the 
change to use the return value of split() doesn't hurt?

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/

  reply	other threads:[~2022-03-09  9:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09  7:31 Sebastian Huber
2022-03-09  8:26 ` Corinna Vinschen
2022-03-09  8:54 ` Mike Frysinger
2022-03-09  9:02   ` Sebastian Huber [this message]
2022-03-09  9:10   ` Mike Frysinger
2022-03-09 10:03     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=395c086f-f51b-d4c1-5b4a-4df0e8cad273@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).