From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: newlib@sourceware.org
Subject: Re: Cygwin strptime() is missing "%s" which strftime() has
Date: Wed, 26 Jul 2017 17:27:00 -0000 [thread overview]
Message-ID: <6ae417fd-e109-4549-f005-5cfa7b6fdb62@SystematicSw.ab.ca> (raw)
In-Reply-To: <20170726104918.GF14419@calimero.vinschen.de>
On 2017-07-26 04:49, Corinna Vinschen wrote:
> On Jul 25 14:13, Brian Inglis wrote:
>> On 2017-07-25 12:52, Corinna Vinschen wrote:
>>> On Jul 25 10:47, Brian Inglis wrote:
>>>> On 2017-07-25 03:16, Corinna Vinschen wrote:
>>>>> [...]
>>>>> I don't think we need to use intmax_t at all here. Checking for
>>>>> LLONG_MAX should be sufficient. However, this is strptime_l. so you
>>>>> should use strtoll_l/strtol_l, just like the rest of the function.
>>>>>
>>>>> On second thought, do we have to do this at all? Our time_t is always
>>>>> long anyway so using just strtol_l and checking for ERANGE should be
>>>>> sufficient:
>>>>>
>>>>> int old_errno = _REENT->_errno;
>>>>> sec = strtol_l (buf, &s, 10);
>>>>> int new_errno = _REENT->_errno;
>>>>> _REENT->_errno = old_errno;
>>>>> if (s == buf || new_errno == ERANGE || etc...
>>>>>
>>>>>> + BIG_T sec;
>>>>>> + time_t t;
>>>>>> +
>>>>>> + sec = STRTOBIG (buf, &s, 10);
>>>>>> + t = (time_t)sec;
>>>>>> + if (s == buf
>>>>>> + || (BIG_T)t != sec
>>>>>> + || localtime_r (&t, timeptr) != timeptr)
>>>>
>>>> Is time_t always long on all newlib platforms, or could it be long
>>>> long in some environments/memory models e.g. Windows 64 VS/MinGW
>>>> LLP64/IL32P64 vs Cygwin/Unix LP64/I32LP64? Could/should we keep the
>>>> strtol[l] options and use the ..._l variants?
>>>
>>> Well... on *third* thought, targets may redefine time_t via redefining
>>> _TIME_T_. Targets not doing that will get long, so yeah, you're right.
>>> Maybe it is safer to use always strtoll_l and just break this down to
>>> time_t on the way.
>>
>> My concern has always been do all newlib RTEMS targets support long
>> long, even if same as long, and stroll_l?
>
> Yes. The long long functions are not excluded like we do with long
> double stuff.
>
>> Trying to build standalone or combined STC for this with changed strptime.c
>> ld/collect2 fails to resolve ...global_locale.
>
> Yeah, it's an internal function to newlib. You need to include
> libc/locale/setlocale.h somehow to accomplish that. STC from Cygwin
> userspace will do.
Not doing it for me: that's why I asked if there were undistributed locale
changes in the tree, and maybe in a dev snapshot?
$ gcc -Wall -Wextra -o strptime_test -I newlib-cygwin/newlib/libc/locale/
strptime_test.c newlib-cygwin/newlib/libc/time/strptime.c
/tmp/ccbcaAPQ.o:strptime.c:(.rdata$.refptr.__global_locale[.refptr.__global_locale]+0x0):
undefined reference to `__global_locale'
collect2: error: ld returned 1 exit status
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
next prev parent reply other threads:[~2017-07-26 17:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BY1PR09MB0343663DE41D927E67CF0CCEA5BB0@BY1PR09MB0343.namprd09.prod.outlook.com>
[not found] ` <acc19ec5-055b-1bd4-997d-a247755163bf@SystematicSw.ab.ca>
2017-07-24 20:42 ` Brian Inglis
2017-07-24 21:36 ` Craig Howland
2017-07-24 23:04 ` Brian Inglis
2017-07-25 9:19 ` Corinna Vinschen
2017-07-25 9:16 ` Corinna Vinschen
2017-07-25 16:47 ` Brian Inglis
2017-07-25 17:38 ` Craig Howland
2017-07-25 18:52 ` Corinna Vinschen
2017-07-25 20:13 ` Brian Inglis
2017-07-26 10:49 ` Corinna Vinschen
2017-07-26 17:27 ` Brian Inglis [this message]
2017-07-26 19:34 ` Corinna Vinschen
2017-07-28 20:50 ` Brian Inglis
2017-07-31 9:55 ` Corinna Vinschen
2017-08-18 18:53 ` Corinna Vinschen
2017-08-18 19:38 ` Brian Inglis
2017-08-18 19:38 ` Brian Inglis
2017-08-18 20:01 ` Brian Inglis
2017-08-19 14:01 ` Brian Inglis
2017-08-21 3:09 ` Brian Inglis
2017-08-21 9:10 ` Corinna Vinschen
2017-08-24 2:14 ` [PATCH] newlib/libc/time/strptime.c(strptime_l) add strptime %F %s Brian Inglis
2017-08-24 8:50 ` Corinna Vinschen
2017-08-25 5:30 ` Brian Inglis
2017-08-25 12:06 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae417fd-e109-4549-f005-5cfa7b6fdb62@SystematicSw.ab.ca \
--to=brian.inglis@systematicsw.ab.ca \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).