From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib/libc/time/strptime.c(strptime_l) add strptime %F %s
Date: Fri, 25 Aug 2017 12:06:00 -0000 [thread overview]
Message-ID: <20170825120505.GA7636@calimero.vinschen.de> (raw)
In-Reply-To: <6ebefa17-14ff-9cac-c316-2d8f80ba9025@SystematicSw.ab.ca>
[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]
On Aug 24 13:18, Brian Inglis wrote:
> On 2017-08-24 02:44, Corinna Vinschen wrote:
> > Hi Brian,
> > On Aug 23 12:59, Brian Inglis wrote:
> >> On 2017-08-21 03:01, Corinna Vinschen wrote:
> >>> Oh, right! I forget about it *blush*
> >> Attached patch to support %F and %s in newlib libc time strptime.c strptime_l().
> >> In case the issue comes up, if the user wants to support %s as in date(1) with a
> >> preceding @ flag, they just have to include that verbatim before the format as
> >> in "@%s".
> >> Is there any way to test this newlib function on a Cygwin platform?
> >> I don't have access to a supported platform.
> >> Similar patch submitted for Cygwin %s.
> > Debugging residue?
> > Opening brace on next line, please, indented as the closing brace.
> > Other than the above, looks good.
>
> Sorry about that - totally missed it - both fixed in attached patch.
>
> --
> Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
> From 3ee59712cd04a6fbaa074b83c92c17bfb5f2e7f1 Mon Sep 17 00:00:00 2001
> From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
> Date: Thu, 24 Aug 2017 13:12:17 -0600
> Subject: [PATCH] newlib/libc/time/strptime.c(strptime_l) add %F %s support for
> strptime
>
> ---
> newlib/libc/time/strptime.c | 34 ++++++++++++++++++++++++++++++++--
> 1 file changed, 32 insertions(+), 2 deletions(-)
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-08-25 12:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BY1PR09MB0343663DE41D927E67CF0CCEA5BB0@BY1PR09MB0343.namprd09.prod.outlook.com>
[not found] ` <acc19ec5-055b-1bd4-997d-a247755163bf@SystematicSw.ab.ca>
2017-07-24 20:42 ` Cygwin strptime() is missing "%s" which strftime() has Brian Inglis
2017-07-24 21:36 ` Craig Howland
2017-07-24 23:04 ` Brian Inglis
2017-07-25 9:19 ` Corinna Vinschen
2017-07-25 9:16 ` Corinna Vinschen
2017-07-25 16:47 ` Brian Inglis
2017-07-25 17:38 ` Craig Howland
2017-07-25 18:52 ` Corinna Vinschen
2017-07-25 20:13 ` Brian Inglis
2017-07-26 10:49 ` Corinna Vinschen
2017-07-26 17:27 ` Brian Inglis
2017-07-26 19:34 ` Corinna Vinschen
2017-07-28 20:50 ` Brian Inglis
2017-07-31 9:55 ` Corinna Vinschen
2017-08-18 18:53 ` Corinna Vinschen
2017-08-18 19:38 ` Brian Inglis
2017-08-18 19:38 ` Brian Inglis
2017-08-18 20:01 ` Brian Inglis
2017-08-19 14:01 ` Brian Inglis
2017-08-21 3:09 ` Brian Inglis
2017-08-21 9:10 ` Corinna Vinschen
2017-08-24 2:14 ` [PATCH] newlib/libc/time/strptime.c(strptime_l) add strptime %F %s Brian Inglis
2017-08-24 8:50 ` Corinna Vinschen
2017-08-25 5:30 ` Brian Inglis
2017-08-25 12:06 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825120505.GA7636@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).