From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Craig Howland <howland@LGSInnovations.com>, newlib@sourceware.org
Subject: Re: [PATCH] Use __BSD_VISIBLE for RTEMS <sys/_termios.h>
Date: Wed, 24 May 2017 05:42:00 -0000 [thread overview]
Message-ID: <779f4e8d-840a-2887-b432-a8bad9bbc93a@embedded-brains.de> (raw)
In-Reply-To: <63f3609c-9556-f093-5b0d-98da23faa293@LGSInnovations.com>
On 23/05/17 17:16, Craig Howland wrote:
> On 05/23/2017 04:23 AM, Sebastian Huber wrote:
>> The Termios header <sys/_termios.h> used _POSIX_SOURCE directly to
>> determine if a thing should be exposed to the user. This circumvented
>> the feature mechanisms of <sys/cdefs.h>.
> Would you please explain why !_POSIX_SOURCE being replaced with
> __BSD_VISIBLE rather than, for example, !__POSIX_VISIBLE?
A negation of visibility define makes no sense.
> That is, you seem to not only be updating to sys/features.h macro
> names, but also shifting exactly how the gate is done. (I'm not
> saying it is necessarily incorrect, just that the explanation does not
> mention the logic change. The two are not logical opposites, so an
> implication is that the original gate of POSIX is not really the right
> one.)
This is an import from FreeBSD. To me this looks like FreeBSD forgot to
update the Termios headers to use the visibility defines.
https://lists.freebsd.org/pipermail/freebsd-hackers/2017-May/051069.html
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
next prev parent reply other threads:[~2017-05-24 5:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 8:23 Sebastian Huber
2017-05-23 15:16 ` Craig Howland
2017-05-23 21:20 ` Yaakov Selkowitz
2017-05-24 5:42 ` Sebastian Huber [this message]
2017-05-24 9:29 ` Sebastian Huber
2017-05-24 14:51 ` Craig Howland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=779f4e8d-840a-2887-b432-a8bad9bbc93a@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=howland@LGSInnovations.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).