From: Craig Howland <howland@LGSInnovations.com>
To: <newlib@sourceware.org>
Subject: Re: [PATCH] Use __BSD_VISIBLE for RTEMS <sys/_termios.h>
Date: Tue, 23 May 2017 15:16:00 -0000 [thread overview]
Message-ID: <63f3609c-9556-f093-5b0d-98da23faa293@LGSInnovations.com> (raw)
In-Reply-To: <20170523082353.1793-1-sebastian.huber@embedded-brains.de>
On 05/23/2017 04:23 AM, Sebastian Huber wrote:
> The Termios header <sys/_termios.h> used _POSIX_SOURCE directly to
> determine if a thing should be exposed to the user. This circumvented
> the feature mechanisms of <sys/cdefs.h>.
Would you please explain why !_POSIX_SOURCE being replaced with __BSD_VISIBLE
rather than, for example, !__POSIX_VISIBLE? That is, you seem to not only be
updating to sys/features.h macro names, but also shifting exactly how the gate
is done. (I'm not saying it is necessarily incorrect, just that the explanation
does not mention the logic change. The two are not logical opposites, so an
implication is that the original gate of POSIX is not really the right one.)
Craig
>
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
> newlib/libc/sys/rtems/include/sys/_termios.h | 46 ++++++++++++++--------------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/newlib/libc/sys/rtems/include/sys/_termios.h b/newlib/libc/sys/rtems/include/sys/_termios.h
> index c8fe054da..2e7cc36c2 100644
> --- a/newlib/libc/sys/rtems/include/sys/_termios.h
> +++ b/newlib/libc/sys/rtems/include/sys/_termios.h
> @@ -42,15 +42,15 @@
> */
> #define VEOF 0 /* ICANON */
> #define VEOL 1 /* ICANON */
> -#ifndef _POSIX_SOURCE
> +#if __BSD_VISIBLE ...
next prev parent reply other threads:[~2017-05-23 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 8:23 Sebastian Huber
2017-05-23 15:16 ` Craig Howland [this message]
2017-05-23 21:20 ` Yaakov Selkowitz
2017-05-24 5:42 ` Sebastian Huber
2017-05-24 9:29 ` Sebastian Huber
2017-05-24 14:51 ` Craig Howland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f3609c-9556-f093-5b0d-98da23faa293@LGSInnovations.com \
--to=howland@lgsinnovations.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).