public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: Re: [PATCH 1/2] arm: Fix fenv support
Date: Thu, 23 Jul 2020 07:16:08 +0200	[thread overview]
Message-ID: <9f87bd30-c963-3350-9901-cf9bc2f55c0a@embedded-brains.de> (raw)
In-Reply-To: <20200719110112.14255-2-sebastian.huber@embedded-brains.de>

On 19/07/2020 13:01, Sebastian Huber wrote:

> From: Eshan dhawan<eshandhawan51@gmail.com>
>
> The previous fenv support for ARM used the soft-float implementation of
> FreeBSD.  Newlib uses the one from libgcc by default.  They are not
> compatible.  Having an GCC incompatible soft-float fenv support in
> Newlib makes no sense.  A long-term solution could be to provide a
> libgcc compatible soft-float support.  This likely requires changes in
> the GCC configuration.  For now, provide a stub implementation for
> soft-float multilibs similar to RISC-V.
>
> Move implementation to one file and delete now unused files.  Hide
> implementation details.  Remove function parameter names from header
> file to avoid name conflicts.
>
> Provide VFP support if __SOFTFP__ is not defined like glibc.
>
> Reviewed-by: Sebastian Huber<sebastian.huber@embedded-brains.de>
> Signed-off-by: Eshan dhawan<eshandhawan51@gmail.com>
This patch is still an improvement and fixes the ARM support of Newlib. 
It would be nice to commit it and then in a second step split it up into 
individual files.

  reply	other threads:[~2020-07-23  5:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 11:01 [PATCH 0/2] Fix fenv support for ARM Sebastian Huber
2020-07-19 11:01 ` [PATCH 1/2] arm: Fix fenv support Sebastian Huber
2020-07-23  5:16   ` Sebastian Huber [this message]
2020-07-30 22:51   ` Keith Packard
2020-07-19 11:01 ` [PATCH 2/2] arm: Remove superfluous fenv stub files Sebastian Huber
2020-07-23  5:13 ` [PATCH 0/2] Fix fenv support for ARM Sebastian Huber
2020-07-27  8:07   ` Corinna Vinschen
2020-07-29  5:07     ` Sebastian Huber
2020-07-29 15:07       ` Sebastian Huber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f87bd30-c963-3350-9901-cf9bc2f55c0a@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).