From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 0/2] Fix fenv support for ARM
Date: Mon, 27 Jul 2020 10:07:29 +0200 [thread overview]
Message-ID: <20200727080729.GC4206@calimero.vinschen.de> (raw)
In-Reply-To: <b1250912-5044-0b77-b8e6-785766e2b4ec@embedded-brains.de>
On Jul 23 07:13, Sebastian Huber wrote:
> On 19/07/2020 13:01, Sebastian Huber wrote:
>
> > This patch set addresses some issues which popped up while building Newlib for
> > ARM with GCC 10 which enables -fno-common by default.
> >
> > Eshan dhawan (1):
> > arm: Fix fenv support
> >
> > Sebastian Huber (1):
> > arm: Remove superfluous fenv stub files
>
> I just noticed that the stub files I removed are not superfluous. Its seems
> they are necessary to somehow overwrite the default implementations in:
>
> newlib/libm/fenv
>
> There seems to be some build system magic involved here. I guess we have to
> split up fenv.c and move all the functions to individual files matching the
> ones in newlib/libm/fenv?
Splitting is probably better. When you created and tested a new patchset,
feel free to push it.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
next prev parent reply other threads:[~2020-07-27 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 11:01 Sebastian Huber
2020-07-19 11:01 ` [PATCH 1/2] arm: Fix fenv support Sebastian Huber
2020-07-23 5:16 ` Sebastian Huber
2020-07-30 22:51 ` Keith Packard
2020-07-19 11:01 ` [PATCH 2/2] arm: Remove superfluous fenv stub files Sebastian Huber
2020-07-23 5:13 ` [PATCH 0/2] Fix fenv support for ARM Sebastian Huber
2020-07-27 8:07 ` Corinna Vinschen [this message]
2020-07-29 5:07 ` Sebastian Huber
2020-07-29 15:07 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727080729.GC4206@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).