From: Kito Cheng <kito.cheng@gmail.com>
To: Newlib <newlib@sourceware.org>, PkmX <pkmx.tw@gmail.com>
Cc: Corinna Vinschen <vinschen@redhat.com>
Subject: Re: [PATCH] riscv: fix integer wraparound in memcpy
Date: Mon, 27 Jul 2020 16:48:18 +0800 [thread overview]
Message-ID: <CA+yXCZAT7Ds6GS4v6dpZhMmZLDAOaPjYrx0iLr29eSyvaRvxJw@mail.gmail.com> (raw)
In-Reply-To: <20200727081514.GD4206@calimero.vinschen.de>
Hi Chih-Mao:
Thanks for your patch :)
Hi Corinna:
Thanks!
On Mon, Jul 27, 2020 at 4:22 PM Corinna Vinschen via Newlib
<newlib@sourceware.org> wrote:
>
> Hi Chen,
>
> On Jul 24 19:07, PkmX via Newlib wrote:
> > This patch fixes a bug in RISC-V's memcpy implementation where an
> > integer wraparound occurs when src + size < 8 * sizeof(long), causing
> > the word-sized copy loop to be incorrectly entered.
> >
> > Signed-off-by: Chih-Mao Chen <cmchen@andestech.com>
> > ---
> > newlib/libc/machine/riscv/memcpy.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/newlib/libc/machine/riscv/memcpy.c
> > b/newlib/libc/machine/riscv/memcpy.c
> > index 07e8e0076..4098f3ab1 100644
> > --- a/newlib/libc/machine/riscv/memcpy.c
> > +++ b/newlib/libc/machine/riscv/memcpy.c
> > @@ -51,9 +51,9 @@ small:
> > const long *lb = (const long *)b;
> > long *lend = (long *)((uintptr_t)end & ~msk);
> >
> > - if (unlikely (la < (lend - 8)))
> > + if (unlikely (lend - la > 8))
> > {
> > - while (la < (lend - 8))
> > + while (lend - la > 8)
> > {
> > long b0 = *lb++;
> > long b1 = *lb++;
> > --
> > 2.27.0
>
> I pushed this, but I had to fix your patch because your MUA broke
> the layout (line breaks, white spaces).
>
> Would you mind to check your MUA settings or send the patch as
> attachment next time?
>
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
>
prev parent reply other threads:[~2020-07-27 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 11:07 PkmX
2020-07-27 8:15 ` Corinna Vinschen
2020-07-27 8:48 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZAT7Ds6GS4v6dpZhMmZLDAOaPjYrx0iLr29eSyvaRvxJw@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=newlib@sourceware.org \
--cc=pkmx.tw@gmail.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).