public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Marcus Comstedt <marcus@mc.pp.se>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH 0/2] Fixes for big endian RISC-V
Date: Thu, 25 Feb 2021 17:21:55 +0800	[thread overview]
Message-ID: <CA+yXCZAgQhYcY0TN9DRg_-A2rWDTFfXFBRGzPbwWZUavqRJ3rw@mail.gmail.com> (raw)
In-Reply-To: <20210223213117.65475-1-marcus@mc.pp.se>

This patch set is LGTM, verified with RV64 big-endian,
although RV32 big-endian still has some regression yet,
and not clear is library or compiler issue,
but I am fine to accept both patches and then accept further
patches later for RV32 if needed.


On Wed, Feb 24, 2021 at 6:07 AM Marcus Comstedt <marcus@mc.pp.se> wrote:
>
> Hi.
>
> These are two fixes needed for newlib to work correctly on big endian
> RISC-V, support for which is currently being added to gcc.
>
>
>   // Marcus
>
>
> --
>
>  newlib/libc/include/machine/ieeefp.h |  4 ++++
>  newlib/libc/machine/riscv/strcmp.S   | 40 ++++++++++++++++++++++++++++++++----
>  2 files changed, 40 insertions(+), 4 deletions(-)
>

  parent reply	other threads:[~2021-02-25  9:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 21:31 Marcus Comstedt
2021-02-23 21:31 ` [PATCH 1/2] Set __IEEE_BIG_ENDIAN " Marcus Comstedt
2021-02-23 21:31 ` [PATCH 2/2] RISC-V: Fix optimized strcmp on big endian Marcus Comstedt
2021-02-25  9:21 ` Kito Cheng [this message]
2021-02-25 11:15 ` [PATCH 0/2] Fixes for big endian RISC-V Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZAgQhYcY0TN9DRg_-A2rWDTFfXFBRGzPbwWZUavqRJ3rw@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=marcus@mc.pp.se \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).