public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Craig Blackmore <craig.blackmore@embecosm.com>
Cc: Jeff Johnston <jjohnstn@redhat.com>, Newlib <newlib@sourceware.org>
Subject: Re: [PATCH] RISC-V: Add semihosting support
Date: Wed, 16 Dec 2020 16:43:00 +0800	[thread overview]
Message-ID: <CA+yXCZB1Fr6TGpb5_Xhj-VRH7pfCMwYFs+2ZK=Y3_RMa+LrMmg@mail.gmail.com> (raw)
In-Reply-To: <3ef25bfd-65d7-e8a2-cdd6-0b0532b5c4f6@embecosm.com>

Hi Craig:

The v2 patch is LGTM, verified with qemu again, thank you!

> I can use SEMIHOST_exit_extended, but I will also need to add a check for the
> SH_EXT_EXIT_EXTENDED feature. Can I follow up with this in a later patch?

OK to me :)

  reply	other threads:[~2020-12-16  8:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 11:36 Craig Blackmore
2020-11-30 14:05 ` Kito Cheng
2020-11-30 19:53 ` Jeff Johnston
2020-12-09  8:21 ` Kito Cheng
2020-12-15 12:00   ` Craig Blackmore
2020-12-15 22:51     ` Jeff Johnston
2020-12-16  8:33       ` Craig Blackmore
2020-12-16  8:43         ` Kito Cheng [this message]
2020-12-16 23:31         ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+yXCZB1Fr6TGpb5_Xhj-VRH7pfCMwYFs+2ZK=Y3_RMa+LrMmg@mail.gmail.com' \
    --to=kito.cheng@gmail.com \
    --cc=craig.blackmore@embecosm.com \
    --cc=jjohnstn@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).