Re: Error in posix_spawn(3) man page

[Keith Thompson <Keith.S.Thompson@gmail.com>]

On Wed, Jan 5, 2022 at 3:47 AM Corinna Vinschen <vinschen@redhat.com> wrote:
>
> Hi Keith,
>
> On Dec 28 19:24, Keith Thompson wrote:
> > The posix_spawn(3) man page has incorrect types for the argv and
> > envp parameters for the posix_spawn and posix_spawnp functions.
> >
> > They're shown as
> >     char *const argv, char *const envp
> > when they should be
> >     char *const argv[], char *const envp[]
> >
> > Suggested patch (though I'm not 100% sure how the square brackets
> > are handled when generating the man page):
>
> Please send a git compatible patch in `git format-patch' format.
>
>
> Thanks,
> Corinna

As requested. Given the way I copy-and-pasted the patch into my email,
it might not have
treated tabs correctly. If you prefer I can send the patch as an
attachment, or you can download
it from
https://smov.org/~kst/0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch

From f4a41189d86bc208a90e754387294b9c4c11cdfc Mon Sep 17 00:00:00 2001
From: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Wed, 5 Jan 2022 13:30:16 -0800
Subject: [PATCH] Fix documented argv and envp params for posix_spawn

---
 newlib/libc/posix/posix_spawn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git newlib/libc/posix/posix_spawn.c newlib/libc/posix/posix_spawn.c
index 005471fde..85bfa6477 100644
--- newlib/libc/posix/posix_spawn.c
+++ newlib/libc/posix/posix_spawn.c
@@ -39,11 +39,11 @@ SYNOPSIS
  int posix_spawn(pid_t *<[pid]>, const char *<[path]>,
  const posix_spawn_file_actions_t *<[file_actions]>,
  const posix_spawnattr_t *<[attrp]>,
- char *const <[argv]>, char *const <[envp]>);
+ char *const <[argv]>[], char *const <[envp]>[]);
  int posix_spawnp(pid_t *<[pid]>, const char *<[file]>,
  const posix_spawn_file_actions_t *<[file_actions]>,
  const posix_spawnattr_t *<[attrp]>,
- char *const <[argv]>, char *const <[envp]>);
+ char *const <[argv]>[], char *const <[envp]>[]);

 DESCRIPTION
 Use <<posix_spawn>> and <<posix_spawnp>> to create a new child process
-- 
2.33.1