From: Keith Thompson <Keith.S.Thompson@gmail.com>
To: newlib@sourceware.org
Cc: Keith Thompson <Keith.S.Thompson@gmail.com>
Subject: Re: Error in posix_spawn(3) man page
Date: Fri, 7 Jan 2022 16:01:17 -0800 [thread overview]
Message-ID: <CAAHpriOUey_wmtyymax4xPW9sVAr3BSypMm6tu7xBzU3=hEXow@mail.gmail.com> (raw)
In-Reply-To: <YdgInET872MEGiU8@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]
On Fri, Jan 7, 2022 at 1:32 AM Corinna Vinschen <vinschen@redhat.com> wrote:
>
> Hi Keith,
>
> On Jan 5 13:39, Keith Thompson wrote:
> > On Wed, Jan 5, 2022 at 3:47 AM Corinna Vinschen <vinschen@redhat.com> wrote:
> > >
> > > Hi Keith,
> > >
> > > On Dec 28 19:24, Keith Thompson wrote:
> > > > The posix_spawn(3) man page has incorrect types for the argv and
> > > > envp parameters for the posix_spawn and posix_spawnp functions.
> > > >
> > > > They're shown as
> > > > char *const argv, char *const envp
> > > > when they should be
> > > > char *const argv[], char *const envp[]
> > > >
> > > > Suggested patch (though I'm not 100% sure how the square brackets
> > > > are handled when generating the man page):
> > >
> > > Please send a git compatible patch in `git format-patch' format.
> > >
> > >
> > > Thanks,
> > > Corinna
> >
> > As requested. Given the way I copy-and-pasted the patch into my email,
> > it might not have
> > treated tabs correctly.
>
> It's not TABs, it's an incorrect patch format:
>
> $ git am 0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch
> Applying: Fix documented argv and envp params for posix_spawn
> error: libc/posix/posix_spawn.c: does not exist in index
> Patch failed at 0001 Fix documented argv and envp params for posix_spawn
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> [...]
>
> Did you actually create the patch with `git format-patch'?
>
>
> Thanks,
> Corinna
The problem was that I had diff.noprefix=true in my $HOME/.gitconfig.
It caused `git format-patch` to omit the `a/` and `b/` prefixes, and `git am`
doesn't appear to have any way to consume a patch with those prefixes missing.
I've attached an updated patch that should apply cleanly.
(I'd argue that this is a git bug, but of course this isn't the place
to report it.)
[-- Attachment #2: 0001-Fix-documented-argv-and-envp-params-for-posix_spawn.patch --]
[-- Type: application/octet-stream, Size: 1150 bytes --]
From 7fdfe8c2549b53ea36d68b879020e0236d6480ac Mon Sep 17 00:00:00 2001
From: Keith Thompson <Keith.S.Thompson@gmail.com>
Date: Wed, 5 Jan 2022 13:30:16 -0800
Subject: [PATCH] Fix documented argv and envp params for posix_spawn
---
newlib/libc/posix/posix_spawn.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/newlib/libc/posix/posix_spawn.c b/newlib/libc/posix/posix_spawn.c
index 005471fde..85bfa6477 100644
--- a/newlib/libc/posix/posix_spawn.c
+++ b/newlib/libc/posix/posix_spawn.c
@@ -39,11 +39,11 @@ SYNOPSIS
int posix_spawn(pid_t *<[pid]>, const char *<[path]>,
const posix_spawn_file_actions_t *<[file_actions]>,
const posix_spawnattr_t *<[attrp]>,
- char *const <[argv]>, char *const <[envp]>);
+ char *const <[argv]>[], char *const <[envp]>[]);
int posix_spawnp(pid_t *<[pid]>, const char *<[file]>,
const posix_spawn_file_actions_t *<[file_actions]>,
const posix_spawnattr_t *<[attrp]>,
- char *const <[argv]>, char *const <[envp]>);
+ char *const <[argv]>[], char *const <[envp]>[]);
DESCRIPTION
Use <<posix_spawn>> and <<posix_spawnp>> to create a new child process
--
2.33.1
next prev parent reply other threads:[~2022-01-08 0:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 3:24 Keith Thompson
[not found] ` <DM3P110MB0522D24ED83275B9EC07839A9A449@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-12-29 16:59 ` Fw: " C Howland
2022-01-05 11:46 ` Corinna Vinschen
2022-01-05 21:39 ` Keith Thompson
2022-01-07 9:32 ` Corinna Vinschen
2022-01-07 19:03 ` Brian Inglis
2022-01-07 20:02 ` Keith Thompson
2022-01-08 0:01 ` Keith Thompson [this message]
2022-01-08 4:30 ` Keith Thompson
2022-01-10 8:58 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAHpriOUey_wmtyymax4xPW9sVAr3BSypMm6tu7xBzU3=hEXow@mail.gmail.com' \
--to=keith.s.thompson@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).