From: Joel Sherrill <joel@rtems.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: Newlib <newlib@sourceware.org>, Chris Johns <chrisj@rtems.org>
Subject: Re: Include FD_SETSIZE on RTEMS to 256
Date: Wed, 13 Mar 2024 09:35:57 -0500 [thread overview]
Message-ID: <CAF9ehCWiBQyY9Hdj_whOce3vHP=CVx68UfVgkQu2uB14eKwUHw@mail.gmail.com> (raw)
In-Reply-To: <9514182a-f513-4296-8178-43b5274abb7f@dronecode.org.uk>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Wed, Mar 13, 2024 at 9:21 AM Jon Turney <jon.turney@dronecode.org.uk>
wrote:
> On 28/02/2024 23:02, Joel Sherrill wrote:
> > Hi
> >
> > The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
> >
> > Is it OK to apply?
> >
>
> This uses the preprocessor directive '#elifdef',
>
> It seems like support for that was added in gcc 12.
>
Good catch. Unfortunately, I just pushed the posted patch just before your
email arrived.
I have posted a small patch to change this to #elif defined(__rtems__). If
someone acks it, I will push it quickly to minimize who might be impacted.
There should be no dependencies in newlib for any toolchain that is that
recent.
--joel
next prev parent reply other threads:[~2024-03-13 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 23:02 Joel Sherrill
2024-02-29 6:29 ` Sebastian Huber
2024-02-29 6:31 ` Sebastian Huber
2024-02-29 14:24 ` Joel Sherrill
2024-03-11 14:50 ` Joel Sherrill
2024-03-12 17:13 ` Corinna Vinschen
2024-03-13 14:21 ` Jon Turney
2024-03-13 14:35 ` Joel Sherrill [this message]
2024-03-13 15:02 ` Corinna Vinschen
2024-03-13 16:03 ` Joel Sherrill
2024-03-13 16:33 ` Joel Sherrill
2024-03-13 17:06 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF9ehCWiBQyY9Hdj_whOce3vHP=CVx68UfVgkQu2uB14eKwUHw@mail.gmail.com' \
--to=joel@rtems.org \
--cc=chrisj@rtems.org \
--cc=jon.turney@dronecode.org.uk \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).