From: Joel Sherrill <joel@rtems.org>
To: newlib@sourceware.org, Joel Sherrill <joel@rtems.org>,
Jennifer Averett <jennifer.averett@oarcorp.com>
Subject: Re: [PATCH 0/3]: Add math support for non LDBL_EQ_DBL architecture
Date: Thu, 6 Apr 2023 09:06:57 -0500 [thread overview]
Message-ID: <CAF9ehCXtOeMY1ee+qTdfYiWWWWC1Yhgwb3AW+SyO+0W4JAiocQ@mail.gmail.com> (raw)
In-Reply-To: <ZC6KOnEIiJqWqKyt@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]
On Thu, Apr 6, 2023 at 4:00 AM Corinna Vinschen <vinschen@redhat.com> wrote:
> On Apr 5 10:44, Joel Sherrill wrote:
> > On Wed, Apr 5, 2023 at 4:23 AM Corinna Vinschen <vinschen@redhat.com>
> wrote:
> > > I noticed that you exclude Cygwin from the new code, which makes sense
> > > as long as we provide our own long double math taken from Mingw-w64.
> >
> > What needs to happen for Cygwin/Mingw_w64? Honestly, we didn't discuss
> > that at all.
>
> Not sure I understand the question. After the patch, Cygwin should
> just still work. Mingw-w64 isn't supported by newlib. What do you
> mean?
>
I was just worried there was something special we needed to account for
that we didn't. I'm glad we didn't miss anything there. No worries. :)
>
> > > However, there's something not quite right. When trying to build I get
> > > symbol conflicts for the fdim{f,l} and scalbln{f,l} symbols in the link
> > > stage (paths shortend for readability):
> > > [...]
> >
> > We chatted and those will be fixed in the next round.
>
> Thanks.
>
> > Anything else you think needs tidying up?
>
> Well, yes. The patch introduces a new header <sys/endian.h>. Cygwin
> already maintains an <endian.h> header, as on Linux.
>
> The way we install header files is that first, the newlib headers are
> installed, and then, second, Cygwin headers are installed, thus
> overriding newlib headers with Cygwin headers as required. We have to
> maintain <endian.h> for userspace compatibility, but after the
> installation user will find two different versions of endian.h,
> one in /usr/include, one in /usr/include/sys.
>
> Would it make a lot of problems to move <sys/endian.h> to <endian.h>?
>
Probably not. Just a matter of the final <endian.h> being a proper union
of the two. It's just software after all.
--joel
>
>
> Thanks,
> Corinna
>
>
>
next prev parent reply other threads:[~2023-04-06 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 20:58 Jennifer Averett
2023-04-03 20:58 ` [PATCH 1/3] newlib: Add FreeBSD files for non LDBL_EQ_DBL support Jennifer Averett
2023-04-03 20:58 ` [PATCH 2/3] newlib: Add non LDBL_EQ_DBL math support for aarch64, i386, and x86_64 Jennifer Averett
2023-04-03 20:58 ` [PATCH 3/3] newlib: Regenerated source for adding non LDBL_EQ_DBL math methods Jennifer Averett
2023-04-05 9:23 ` [PATCH 0/3]: Add math support for non LDBL_EQ_DBL architecture Corinna Vinschen
2023-04-05 15:44 ` Joel Sherrill
2023-04-06 9:00 ` Corinna Vinschen
2023-04-06 14:06 ` Joel Sherrill [this message]
2023-04-06 16:23 ` Corinna Vinschen
2023-04-05 20:12 ` Jeff Johnston
2023-04-05 21:34 ` Joel Sherrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF9ehCXtOeMY1ee+qTdfYiWWWWC1Yhgwb3AW+SyO+0W4JAiocQ@mail.gmail.com \
--to=joel@rtems.org \
--cc=jennifer.averett@oarcorp.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).