From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Olivier MARTIN <olivier@labapart.com>
Cc: Newlib Mailing List <newlib@sourceware.org>
Subject: Re: Building newlib for Cortex-M with LLVM
Date: Thu, 12 Nov 2015 11:17:00 -0000 [thread overview]
Message-ID: <CAFqB+Pwg=bP5idYRTDTLtjxNfZMvuf3KeyPSMKLiJQ+Y3Nnsiw@mail.gmail.com> (raw)
In-Reply-To: <8473a04381ff7d35caa7ea1e8eb08772@labapart.com>
On 11 November 2015 at 23:16, Olivier MARTIN <olivier@labapart.com> wrote:
> * The first one can be solved. The space in the call of CONCAT2(a, b) by
> CONCAT() is propagated into the subsequent calls. It means when the strings
> 'a' and 'b' are concatenated, the space is inserted between both strings -
> which is not the expected behaviour.
>
> The fix would be:
>
> --- a/newlib/libc/machine/arm/setjmp.S
> +++ b/newlib/libc/machine/arm/setjmp.S
> @@ -3,7 +3,7 @@
> Nick Clifton, Cygnus Solutions, 13 June 1997. */
>
> /* ANSI concatenation macros. */
> -#define CONCAT(a, b) CONCAT2(a, b)
> +#define CONCAT(a, b) CONCAT2(a,b)
Have you looked at the C standard on this issue? I wonder which
compiler, gcc or clang is not compliant with the standard.
Cheers
/Marcus
next prev parent reply other threads:[~2015-11-12 10:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 4:11 Olivier MARTIN
2015-11-12 11:17 ` Marcus Shawcroft [this message]
2015-11-12 12:39 ` Clemens Ladisch
2015-11-12 13:46 ` Olivier MARTIN
2015-11-12 14:22 ` Richard Earnshaw
2015-11-12 15:33 ` Olivier MARTIN
2015-11-12 15:50 ` Richard Earnshaw
2015-11-12 15:56 ` Olivier MARTIN
2015-11-12 15:59 ` Richard Earnshaw
2015-11-12 22:42 ` Jonathan Roelofs
2017-06-15 10:52 ` Emmanuel Blot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqB+Pwg=bP5idYRTDTLtjxNfZMvuf3KeyPSMKLiJQ+Y3Nnsiw@mail.gmail.com' \
--to=marcus.shawcroft@gmail.com \
--cc=newlib@sourceware.org \
--cc=olivier@labapart.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).