From: Jeffrey Walton <noloader@gmail.com>
To: newlib@sourceware.org
Subject: Re: Use of initialized variable in strtod.c
Date: Wed, 15 Mar 2017 19:31:00 -0000 [thread overview]
Message-ID: <CAH8yC8mi12c2thv8nUibrgO_cjqj5z3St=LyyXJuNuAPR+YiZw@mail.gmail.com> (raw)
In-Reply-To: <2264cd14-0e03-2aad-f95e-562394435c0b@LGSInnovations.com>
> Does Coverity have a way in which in the code it can be marked as OK? (I'd
> expect some '#pragma CoverityIgnore(bits)' or the like ought to be
> available.)
Yes. You have to provide a modeling file. Also see the Coverity Scan
FAQ entry "what is a model" at https://scan.coverity.com/faq.
Other projects use them, like Python. See, for example,
https://docs.python.org/devguide/coverity.html.
> I agree with trying to get rid of the message, but it is worth
> bloat to do it? (It will add instructions to either initialize bits to 0 or
> add the else.)
If I am parsing things correctly, it seems like the bloat is going the
other way: if the code is not needed, then remove it. It will avoid
findings like these, and speed up the compile.
> I would rather mark something in the code as a false
> positive than add code because the tool is not smart enough to know--so we
> might differ in philosophy there.
Perhaps a better strategy would be to initialize all variables, and
then allow the optimizer to remove the unneeded writes. It will ensure
a program is in a good state, and avoid findings like these.
Another strategy is to do nothing. In this case, the same findings
will waste multiple developer's time, and generate additional mailing
list messages.
I like dark and silent cockpits, so I don't want tools generating
findings, and I don't want mailing list messages. I would squash it
once and for all and avoid all future problems. But that's just me,
and I understand the Newlib project may have a different outlook on
things.
Jeff
next prev parent reply other threads:[~2017-03-15 19:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 18:16 Joel Sherrill
2017-03-15 18:34 ` Craig Howland
2017-03-15 18:38 ` Joel Sherrill
2017-03-15 18:56 ` Craig Howland
2017-03-15 19:31 ` Jeffrey Walton [this message]
2017-03-15 19:54 ` Joel Sherrill
2017-03-15 20:03 ` Joel Sherrill
2017-03-15 22:37 ` Joel Sherrill
2017-03-15 22:47 ` Craig Howland
2017-03-16 8:32 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH8yC8mi12c2thv8nUibrgO_cjqj5z3St=LyyXJuNuAPR+YiZw@mail.gmail.com' \
--to=noloader@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).