From: Giacomo Tesio <giacomo@tesio.it>
To: newlib@sourceware.org
Subject: Re: Uninitialized structure in printing functions
Date: Thu, 27 Apr 2017 14:56:00 -0000 [thread overview]
Message-ID: <CAHL7psGaXPooxqzCrF3_aXTptcN_Tvo5gf=oFwsmL4kZ_hs3zw@mail.gmail.com> (raw)
In-Reply-To: <CAHL7psEN9A-4MBDkzXnerN1HM9w2_GhZ74-s-Ga9YhOuahh_1A@mail.gmail.com>
Sorry, I've just noticed that -O0 was not enough: I also configured
newlib with --disable-newlib-fwrite-in-streamio actually removing the
uio structures altogether.
Neither -O0 nor --disable-newlib-fwrite-in-streamio were enough alone.
They are needed together to make the hello world test pass.
Giacomo
2017-04-27 16:10 GMT+02:00 Giacomo Tesio <giacomo@tesio.it>:
> Hi, I've just found that with -O0 both my tests and the newlib's
> testsuite work as expected, even removing the uio initialization
> provided in the patch.
>
> This is a bit weird. My cross compiler is GCC 4.9.4: is it possible
> that newlib is not actually tested with this version?
>
>
> Giacomo
>
> 2017-04-26 11:35 GMT+02:00 Giacomo Tesio <giacomo@tesio.it>:
>> Hi Corinna,
>>
>> I was trying to fix a simple "hello, world" test:
>> https://github.com/JehanneOS/jehanne/blob/c2982db8a2c57a3250c129c28bb395715521ec4e/qa/lib/newlib/hello.c.
>>
>> During debug one of the issue I've noticed was a fault related to uio
>> in vfprintf.c:348: apparently uio->uio_resid was uninitialized and
>> actually the patch I provided fixed the test.
>> However with a different test I'm working on now, I've found that
>> zeroing the structures is not enough.
>> Somehow uio->uio_resid overflows there, but I wasn't able yet to
>> identify why or where.
>>
>> Any suggestion is welcome. I supposed I've just hit an untested
>> combination of configure options, but actually --enable-newlib-mb is
>> the only configure option I'm using (except for prefix and target,
>> obviously).
>>
>>
>>
>> Giacomo
>>
>>
>> 2017-04-26 10:24 GMT+02:00 Corinna Vinschen <vinschen@redhat.com>:
>>> On Apr 21 19:03, Giacomo Tesio wrote:
>>>> Hi, during the port to Jehanne, I had issues with the uninitialized
>>>> uio structure in several printing functions.
>>>>
>>>> The attached patch fixes them.
>>>
>>> I'm puzzled what problem you're solving.
>>>
>>> I inspected the code in question and the uio structure is always filled
>>> with values for all three members before using it. Setting uio to 0
>>> in all these places looks gratuitous.
>>>
>>> Can you please explain what exactly you're observing and how setting
>>> uio to all 0 solved this problem?
>>>
>>>
>>> Corinna
>>>
>>> --
>>> Corinna Vinschen
>>> Cygwin Maintainer
>>> Red Hat
prev parent reply other threads:[~2017-04-27 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 18:07 Giacomo Tesio
2017-04-26 8:24 ` Corinna Vinschen
2017-04-26 9:35 ` Giacomo Tesio
2017-04-27 14:10 ` Giacomo Tesio
2017-04-27 14:56 ` Giacomo Tesio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHL7psGaXPooxqzCrF3_aXTptcN_Tvo5gf=oFwsmL4kZ_hs3zw@mail.gmail.com' \
--to=giacomo@tesio.it \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).