From: Corinna Vinschen <vinschen@redhat.com>
To: Giacomo Tesio <giacomo@tesio.it>
Cc: newlib@sourceware.org
Subject: Re: Uninitialized structure in printing functions
Date: Wed, 26 Apr 2017 08:24:00 -0000 [thread overview]
Message-ID: <20170426082427.GD12712@calimero.vinschen.de> (raw)
In-Reply-To: <CAHL7psH=7EPatUD0DgncqvqMdsXapmRem=eM-NYY9sGbs_oN-g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Apr 21 19:03, Giacomo Tesio wrote:
> Hi, during the port to Jehanne, I had issues with the uninitialized
> uio structure in several printing functions.
>
> The attached patch fixes them.
I'm puzzled what problem you're solving.
I inspected the code in question and the uio structure is always filled
with values for all three members before using it. Setting uio to 0
in all these places looks gratuitous.
Can you please explain what exactly you're observing and how setting
uio to all 0 solved this problem?
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-04-26 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 18:07 Giacomo Tesio
2017-04-26 8:24 ` Corinna Vinschen [this message]
2017-04-26 9:35 ` Giacomo Tesio
2017-04-27 14:10 ` Giacomo Tesio
2017-04-27 14:56 ` Giacomo Tesio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426082427.GD12712@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=giacomo@tesio.it \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).